Skip to content

Conversation

@daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Jul 24, 2022

This replaces the hand-written compression implementation with a Tower layer provided by tower-http.

This gets us a couple of improvements:

  • More compression algorithms, including Brotli, which is usually better then gzip.
  • All files are now being automatically compressed.
  • Less code 🎉.

Disadvantages:

@daxpedda
Copy link
Contributor Author

daxpedda commented Jul 31, 2022

Rebased after #14.

@daxpedda
Copy link
Contributor Author

Rebased after #13.

@jakobhellermann
Copy link
Owner

While this is much nicer from an implementation perspective, I decided against doing this because I really wanted to be able to print a representative size of how large a compressed wasm binary would be, which didn't work nicely with just having a generic tower compression layer.

If we want to do compression for other files (e.g. html) or other formats (e.g. brotli) then we can consider that separately in other PRs/issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants