-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(query): Auto-detect UI base path from browser URL (ADR-009) #8568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 27 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
fdf9b22
docs(adr): Add ADR-009 for UI base-path auto-detection
yurishkuro a76b750
feat(query): Remove <base href> injection from static handler
yurishkuro 88d1b3e
docs(adr): Add test plan to ADR-009
yurishkuro cd97bf3
ci(e2e): Add UI reverse-proxy integration tests for ADR-009 use cases
yurishkuro c4131aa
test(e2e): Check all static assets (favicon, CSS, JS) in reverse-prox…
yurishkuro a64d409
refactor(e2e): Consolidate reverse-proxy UCs into a single docker-com…
yurishkuro 7fe5aa3
fix(e2e): Use go env GOARCH instead of uname -m translation
yurishkuro 11ca97f
fix(ci): Use go env GOARCH instead of hardcoded amd64 in ui-reverse-p…
yurishkuro 08b4674
fix(e2e): Fix GitHub Actions log folding for docker compose logs
yurishkuro 3a04a73
fix(query): Validate BasePath in RegisterRoutes; fix test assertions;…
yurishkuro 8c7413b
fix(ci): Set GH_TOKEN for gh pr checkout in ui-reverse-proxy workflow
yurishkuro 173445a
fix(ui): Skip nvm in CI where Node.js is set up by actions/setup-node
yurishkuro 59ed87e
refactor(e2e): Consolidate reverse-proxy configs into examples/revers…
yurishkuro 1cc5dbc
fix(e2e): Add trailing-slash redirects to httpd configs for UC-1 and …
yurishkuro 159b8e8
docs(e2e): Rewrite reverse-proxy README to document all three use cases
yurishkuro 4eeea36
upgrade UI
yurishkuro e87e718
fix(e2e): Address CI review comments — pin httpd, remove UI PR fallba…
yurishkuro 6766a29
refactor(ci): Simplify ui-reverse-proxy workflow — delegate build to …
yurishkuro 25d4cca
fix(query): Validate BasePath in NewStaticAssetsHandler instead of pa…
yurishkuro 5f0e89f
test(query): Remove dead expectedBaseHTML field from TestRegisterStat…
yurishkuro 9f10d59
docs(e2e): Replace v1 --query.base-path with v2 extensions.jaeger_que…
yurishkuro bbb9648
docs(adr): Remove v1 flag reference from ADR-009
yurishkuro 5a695bd
docs(adr): Mark ADR-009 as Implemented; fix stale references
yurishkuro c5432b6
docs(adr): Rewrite ADR-009 Context section to past tense
yurishkuro 9f8c277
fix
yurishkuro 1a6a284
docs(adr): Add Future Improvements section to ADR-009
yurishkuro 3e97965
docs(adr): Expand X-Forwarded-Prefix section with security and comple…
yurishkuro 70a5ecd
fix(e2e): Add trailing-slash redirect for /alt in UC-2 httpd config
yurishkuro 6dbd541
fix(query): Normalize and validate BasePath once in Config.Validate()
yurishkuro 26b73f2
test(query): Assert backend does not inject path-specific <base href>…
yurishkuro a18c795
fix(e2e): Exclude /alt from ProxyPass so Redirect permanent can issue…
yurishkuro 9fccd50
fix(e2e): Use mod_rewrite for exact /alt→/alt/ redirect in UC-2 httpd…
yurishkuro 8d58cb6
fix(query): Reject base_path with duplicate slashes or path traversal
yurishkuro a414b84
fix(query): Improve error message and test assertion clarity
yurishkuro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # Copyright (c) 2026 The Jaeger Authors. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| # E2E integration tests for Jaeger UI served behind a reverse proxy (ADR-009). | ||
| # Validates three use cases in a single job: | ||
| # | ||
| # UC-1: proxy forwards the URL prefix unchanged to Jaeger | ||
| # (exercises the existing examples/reverse-proxy/ setup) | ||
| # UC-2: single Jaeger pod served under two different external prefixes | ||
| # simultaneously, with the proxy stripping the prefix on one path | ||
| # UC-3: proxy rewrites an external prefix to a different internal prefix | ||
| # (the case that motivated ADR-009 / issue #5157) | ||
|
|
||
|
yurishkuro marked this conversation as resolved.
|
||
| name: CIT UI Reverse Proxy | ||
|
|
||
| on: | ||
| workflow_call: | ||
|
|
||
| # See https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions | ||
| permissions: | ||
| contents: read | ||
|
yurishkuro marked this conversation as resolved.
|
||
|
|
||
| jobs: | ||
| ui-reverse-proxy: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Harden Runner | ||
| uses: step-security/harden-runner@a5ad31d6a139d249332a2605b85202e8c0b78450 # v2.19.1 | ||
| with: | ||
| egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs | ||
|
|
||
| - uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0 | ||
| with: | ||
| submodules: true | ||
|
|
||
| - name: Fetch git tags | ||
| run: git fetch --prune --unshallow --tags | ||
|
|
||
| - uses: ./.github/actions/setup-go | ||
| with: | ||
| go-version: 1.26.x | ||
|
|
||
| - name: Setup Node.js version | ||
| uses: ./.github/actions/setup-node.js | ||
|
|
||
| - name: Run UI reverse-proxy integration tests (UC-1, UC-2, UC-3) | ||
| run: bash scripts/e2e/ui-reverse-proxy.sh | ||
|
yurishkuro marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.