Revert metrics workflow changes from PR8106#8175
Merged
Merged
Conversation
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
added
the
changelog:ci
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts CI summary/metrics workflow hardening changes introduced in #8106, restoring stricter metrics comparison enforcement so protections are not weakened in CI.
Changes:
- Re-enable running the metrics comparison step for all PRs (including Dependabot) and remove “skipped” handling.
- Simplify metrics conclusion handling in the CI summary artifact generation (defaulting missing metrics conclusion to failure).
- Remove the “metrics comparison explicitly skipped” pathway from the publish script and its unit tests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/ci-summary-report.yml |
Restores always-on metrics comparison and removes Dependabot-specific bypass/“skipped” logic for metrics gating. |
.github/scripts/ci-summary-report-publish.js |
Removes metrics “skipped” conclusion handling in computeMetrics, making metrics status derive strictly from infra/errors/total changes. |
.github/scripts/ci-summary-report-publish.test.js |
Deletes the unit test case that asserted success when metrics comparison was marked as skipped. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8175 +/- ##
==========================================
- Coverage 95.70% 95.67% -0.03%
==========================================
Files 317 317
Lines 16747 16747
==========================================
- Hits 16027 16023 -4
- Misses 568 571 +3
- Partials 152 153 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jaegertracingbot
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?