Skip to content

Use ifneq instead of ifndef for SKIP_DEBUG_BINARIES check #8039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yurishkuro merged 4 commits into from
Feb 11, 2026
Merged

Use ifneq instead of ifndef for SKIP_DEBUG_BINARIES check #8039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
367357a
Initial plan
Copilot Feb 11, 2026
b81e8eb
Skip debug binary builds on PRs to save CI time
Copilot Feb 11, 2026
f6121ca
Use ifneq instead of ifndef for clearer intent
Copilot Feb 11, 2026
5bdce54
Address review comments: use '0' explicitly and set DEBUG_BINARY on t…
Copilot Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci-build-binaries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,7 @@ jobs:

- name: Build platform binaries
run: make build-binaries-${{ matrix.os }}-${{ matrix.arch }}
env:
# Skip debug binaries on PRs to save CI time (4+ min per arch)
# Debug binaries are still built on main branch and during releases
SKIP_DEBUG_BINARIES: ${{ github.event_name == 'pull_request' && '1' || '0' }}
7 changes: 5 additions & 2 deletions scripts/makefiles/BuildBinaries.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,14 @@ _build-platform-binaries: \
build-es-index-cleaner \
build-es-rollover
# invoke make recursively such that DEBUG_BINARY=1 can take effect
$(MAKE) _build-platform-binaries-debug GOOS=$(GOOS) GOARCH=$(GOARCH) DEBUG_BINARY=1
# skip debug builds if SKIP_DEBUG_BINARIES is set to 1 (e.g., during PRs to save CI time)
ifneq ($(SKIP_DEBUG_BINARIES),1)
$(MAKE) _build-platform-binaries-debug GOOS=$(GOOS) GOARCH=$(GOARCH)
endif

# build binaries that support DEBUG release, for one specific platform GOOS/GOARCH
.PHONY: _build-platform-binaries-debug
_build-platform-binaries-debug:
_build-platform-binaries-debug: DEBUG_BINARY=1
_build-platform-binaries-debug: \
build-jaeger \
build-remote-storage
Expand Down
Loading