Enable unhandled-error linter#7895
Merged
yurishkuro merged 7 commits intoJan 22, 2026
Merged
Conversation
Signed-off-by: Ilia Petrov <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7895 +/- ##
==========================================
+ Coverage 95.50% 95.51% +0.01%
==========================================
Files 312 312
Lines 16511 16512 +1
==========================================
+ Hits 15769 15772 +3
+ Misses 579 577 -2
Partials 163 163
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iypetrov
changed the title
Metrics Comparison SummaryTotal changes across all snapshots: 0 Detailed changes per snapshotsummary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
summary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
summary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
|
Signed-off-by: Ilia Petrov <[email protected]>
Signed-off-by: Ilia Petrov <[email protected]>
iypetrov
changed the title
yurishkuro
requested changes
Jan 21, 2026
Member
yurishkuro
left a comment
yurishkuro
left a comment
There was a problem hiding this comment.
if we're fixing bad pattern let's actually fix it, not simply ignore the error
Signed-off-by: Ilia Petrov <[email protected]>
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Signed-off-by: Ilia Petrov <[email protected]>
yurishkuro
approved these changes
Jan 22, 2026
yurishkuro
added
the
changelog:ci
Merged
via the queue into
jaegertracing:main
with commit Jan 22, 2026
c6bd06d
84 of 86 checks passed
SoumyaRaikwar
pushed a commit
to SoumyaRaikwar/jaeger
that referenced
this pull request
Feb 13, 2026
## Which problem is this PR solving? - Resolves jaegertracing#5506 ## Description of the changes - Enabled the `unhandled-error` rule with required changes to the files. ## How was this change tested? - make test - make lint ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Ilia Petrov <[email protected]>
singhvibhanshu
pushed a commit
to singhvibhanshu/jaeger
that referenced
this pull request
Mar 18, 2026
## Which problem is this PR solving? - Resolves jaegertracing#5506 ## Description of the changes - Enabled the `unhandled-error` rule with required changes to the files. ## How was this change tested? - make test - make lint ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Ilia Petrov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
unhandled-errorrule with required changes to the files.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test