Make SPM integration test faster by flushing metrics more frequently#7861
Merged
yurishkuro merged 1 commit intoFeb 1, 2026
Conversation
Don-Assamongkol1
changed the title
Metrics Comparison SummaryTotal changes across all snapshots: 0 Detailed changes per snapshotsummary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
summary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
summary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
summary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 0
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7861 +/- ##
==========================================
+ Coverage 95.55% 95.57% +0.02%
==========================================
Files 316 316
Lines 16726 16726
==========================================
+ Hits 15982 15986 +4
+ Misses 580 577 -3
+ Partials 164 163 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
reviewed
Jan 10, 2026
yurishkuro
reviewed
Jan 12, 2026
yurishkuro
reviewed
Jan 12, 2026
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Contributor
Author
|
Hey @yurishkuro sorry, I'm still working on this. Would you mind reviewing after I've gotten all changes to pass? Not sure what the flow of this repo is for having an already open PR, then having to fix it-- should I push to another branch or mark it as review for later? |
Don-Assamongkol1
force-pushed
the
5608-SPM-IT-see-if-metrics-are-getting-scraped
branch
5 times, most recently
from
a58ab44 to
ecc976d
Compare
Don-Assamongkol1
force-pushed
the
5608-SPM-IT-see-if-metrics-are-getting-scraped
branch
from
ecc976d to
a3dc783
Compare
Contributor
Author
|
The label check is failing-- Could a maintainer please add a label like |
yurishkuro
added
the
changelog:ci
Contributor
Author
|
@yurishkuro Pr ready for review again |
Don-Assamongkol1
force-pushed
the
5608-SPM-IT-see-if-metrics-are-getting-scraped
branch
from
a3dc783 to
bce6c91
Compare
Don-Assamongkol1
force-pushed
the
5608-SPM-IT-see-if-metrics-are-getting-scraped
branch
2 times, most recently
from
364f319 to
0df3bdc
Compare
Contributor
Author
|
@yurishkuro this PR should be ready to review again. Please lmk if I'm missing anything! |
Don-Assamongkol1
force-pushed
the
5608-SPM-IT-see-if-metrics-are-getting-scraped
branch
from
0df3bdc to
dbc450d
Compare
yurishkuro
reviewed
Jan 31, 2026
yurishkuro
reviewed
Jan 31, 2026
yurishkuro
reviewed
Jan 31, 2026
yurishkuro
added
the
waiting-for-author
Don-Assamongkol1
force-pushed
the
5608-SPM-IT-see-if-metrics-are-getting-scraped
branch
from
dbc450d to
3c18749
Compare
github-actions
Bot
removed
the
waiting-for-author
Signed-off-by: Don Assamongkol <don.assamongkol@gmail.com>
Don-Assamongkol1
force-pushed
the
5608-SPM-IT-see-if-metrics-are-getting-scraped
branch
from
b048fc5 to
23ba328
Compare
Contributor
Author
|
Hmm, not sure why check-label bot is failing this-- The changelog label is still applied I believe. But anyways tested it locally so let's see if the build passes here too |
yurishkuro
approved these changes
Feb 1, 2026
yurishkuro
changed the title
SoumyaRaikwar
pushed a commit
to SoumyaRaikwar/jaeger
that referenced
this pull request
Feb 13, 2026
…aegertracing#7861) ## Which problem is this PR solving? - follow-up to jaegertracing#5608 ## Description of the changes - Speed up integration test by changing the interval at which jaeger flushes metrics. - The set up is `microsim` sends spans to jaeger where Jaeger is running an OTLP collector. Previously, the collector was configured to flush metrics out using the default of 1 min, which is why the integration test had to wait. - log with timestamp - Configured prometheus to scrape poll more frequently. - Query metrics API with a step param = 10 seconds so prometheus computes metrics more frequently - remove old test code that expected zero value metric data points. We don't expect this anymore because metrics are getting populated more quickly ## How was this change tested? - Ran locally. Entire test now takes 1 minute instead of 3 (I think?) previously. (can verify here in CI to double check) ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: Don Assamongkol <don.assamongkol@gmail.com>
singhvibhanshu
pushed a commit
to singhvibhanshu/jaeger
that referenced
this pull request
Mar 18, 2026
…aegertracing#7861) ## Which problem is this PR solving? - follow-up to jaegertracing#5608 ## Description of the changes - Speed up integration test by changing the interval at which jaeger flushes metrics. - The set up is `microsim` sends spans to jaeger where Jaeger is running an OTLP collector. Previously, the collector was configured to flush metrics out using the default of 1 min, which is why the integration test had to wait. - log with timestamp - Configured prometheus to scrape poll more frequently. - Query metrics API with a step param = 10 seconds so prometheus computes metrics more frequently - remove old test code that expected zero value metric data points. We don't expect this anymore because metrics are getting populated more quickly ## How was this change tested? - Ran locally. Entire test now takes 1 minute instead of 3 (I think?) previously. (can verify here in CI to double check) ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: Don Assamongkol <don.assamongkol@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
microsimsends spans to jaeger where Jaeger is running an OTLP collector. Previously, the collector was configured to flush metrics out using the default of 1 min, which is why the integration test had to wait.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test