[clickhouse] Update FindTraceIDs to filter by string attributes #7788
Merged
Conversation
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
added
the
changelog:experimental
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7788 +/- ##
==========================================
- Coverage 95.54% 95.51% -0.03%
==========================================
Files 308 308
Lines 15488 15503 +15
==========================================
+ Hits 14798 14808 +10
- Misses 544 548 +4
- Partials 146 147 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
reviewed
Dec 26, 2025
yurishkuro
approved these changes
Dec 26, 2025
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
ThatDeparted2061
pushed a commit
to ThatDeparted2061/jaeger
that referenced
this pull request
Dec 31, 2025
…egertracing#7788) ## Which problem is this PR solving? - Towards jaegertracing#7134 ## Description of the changes - Updated `FindTraceIDs` for ClickHouse storage to filter by string attributes. ## How was this change tested? - Unit tests - Manual test with a running ClickHouse instance on my machine ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]> Signed-off-by: ThatDeparted2061 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
FindTraceIDsfor ClickHouse storage to filter by string attributes.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test