Fix: Remove tool installation from Go Tip workflow by chinmay3012 · Pull Request #7716 · jaegertracing/jaeger

chinmay3012 · 2025-12-08T19:25:16Z

Which problem is this PR solving?

Resolves [Feature]: Use official Go version for building tools in gotip workflow #7664

Description of the changes

Removed the installation of stable Go and test dependencies (make install-test-tools) from the
ci-unit-tests-go-tip.yml
workflow.
Removed the "Lint" step, which was previously a placeholder and not performing actual linting in this workflow.
This ensures that tools (like linters) are not built using the potentially unstable Go Tip version, preventing unrelated build failures during Go Tip testing. The workflow now strictly focuses on compiling and running unit tests for Jaeger's core code against Go Tip.

How was this change tested?

Tested by verifying that the workflow configuration is valid and correctly invokes make test-ci without the unnecessary prerequisite steps.
The change purely modifies the CI configuration to align with the requirement of not testing tools against Go Tip.

yurishkuro

Good call, we don't need to install tools just to run tests.

Please enable the workflow for PR temporarily to validate it works.

chinmay3012 · 2025-12-08T19:47:15Z

Thanks! I've updated the workflow file to temporarily run on this PR. Testing it now to confirm everything works without the tool installation steps. I'll revert this specific change once we verify the tests pass.

Signed-off-by: Chinmay Mehrotra <[email protected]>

…atest docker digest (jaegertracing#7678) This PR contains the following updates: | Package | Update | Change | |---|---|---| | cr.jaegertracing.io/jaegertracing/jaeger | digest | `b585df1` -> `d5e5fe1` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - "on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/jaegertracing/jaeger).  --------- Signed-off-by: Mend Renovate <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Mahad Zaryab <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Chinmay Mehrotra <[email protected]>

Signed-off-by: Chinmay Mehrotra <[email protected]>

Signed-off-by: Yuri Shkuro <[email protected]>

yurishkuro · 2025-12-08T19:52:39Z

do not update until we have successful run https://github.com/jaegertracing/jaeger/actions/runs/20040863435/job/57474277263?pr=7716

yurishkuro · 2025-12-08T19:58:27Z

ok it looks like it works, the unit tests are executing. Reverting the workflow skip for final CI.

Signed-off-by: Yuri Shkuro <[email protected]>

yurishkuro · 2025-12-08T20:01:14Z

Running on main, looks good https://github.com/jaegertracing/jaeger/actions/runs/20041030941/job/57474858357

@chinmay3012 thanks

github-actions · 2025-12-08T20:02:26Z

Metrics Comparison Summary

Total changes across all snapshots: 53

Detailed changes per snapshot

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

Total Changes: 53

🆕 Added: 53 metrics
❌ Removed: 0 metrics
🔄 Modified: 0 metrics

🆕 Added Metrics

http_server_request_body_size_bytes (18 variants)

View diff sample

+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

- `http_server_request_duration_seconds` (17 variants)

View diff sample

+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.005",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.01",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.025",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.05",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.075",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.1",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

- `http_server_response_body_size_bytes` (18 variants)

View diff sample

+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

➡️ View full metrics file

chinmay3012 · 2025-12-09T07:01:42Z

Running on main, looks good https://github.com/jaegertracing/jaeger/actions/runs/20041030941/job/57474858357

@chinmay3012 thanks

Looking forward to connect and dive into more complex contribution . Thanks @yurishkuro

## Which problem is this PR solving? - Resolves jaegertracing#7664 ## Description of the changes - Removed the installation of stable Go and test dependencies (make install-test-tools) from the ci-unit-tests-go-tip.yml workflow. - Removed the "Lint" step, which was previously a placeholder and not performing actual linting in this workflow. - This ensures that tools (like linters) are not built using the potentially unstable Go Tip version, preventing unrelated build failures during Go Tip testing. The workflow now strictly focuses on compiling and running unit tests for Jaeger's core code against Go Tip. ## How was this change tested? - Tested by verifying that the workflow configuration is valid and correctly invokes make test-ci without the unnecessary prerequisite steps. - The change purely modifies the CI configuration to align with the requirement of not testing tools against Go Tip. --------- Signed-off-by: Chinmay Mehrotra <[email protected]> Signed-off-by: Mend Renovate <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Chinmay Mehrotra <[email protected]> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Mahad Zaryab <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: SoumyaRaikwar <[email protected]>

chinmay3012 requested a review from a team as a code owner December 8, 2025 19:25

chinmay3012 requested a review from albertteoh December 8, 2025 19:25

yurishkuro reviewed Dec 8, 2025

View reviewed changes

yurishkuro added the changelog:ci Change related to continuous integration / testing label Dec 8, 2025

yurishkuro reviewed Dec 8, 2025

View reviewed changes

Comment thread .github/workflows/ci-unit-tests-go-tip.yml

chinmay3012 and others added 4 commits December 9, 2025 01:20

Fix: Remove tool installation from Go Tip workflow

26e3bc9

Signed-off-by: Chinmay Mehrotra <[email protected]>

Temporarily enable Go Tip workflow for PR validation

3ef47b3

Signed-off-by: Chinmay Mehrotra <[email protected]>

Revert "Temporarily enable Go Tip workflow for PR validation"

0423675

Signed-off-by: Chinmay Mehrotra <[email protected]>

chinmay3012 force-pushed the #7664 branch from b221902 to 0423675 Compare December 8, 2025 19:50

chinmay3012 and others added 2 commits December 9, 2025 01:21

Merge branch 'main' into jaegertracing#7664

c51ae73

Apply suggestion from @yurishkuro

5baffc0

Signed-off-by: Yuri Shkuro <[email protected]>

yurishkuro reviewed Dec 8, 2025

View reviewed changes

Comment thread .github/workflows/ci-unit-tests-go-tip.yml Outdated

Apply suggestion from @yurishkuro

ef8693b

Signed-off-by: Yuri Shkuro <[email protected]>

yurishkuro merged commit b728d61 into jaegertracing:main Dec 8, 2025
1 check passed

Copilot AI mentioned this pull request Dec 10, 2025

Replace manual release build process with goreleaser (v2 only) #7693

Closed

chinmay3012 deleted the #7664 branch December 10, 2025 04:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Remove tool installation from Go Tip workflow#7716

Fix: Remove tool installation from Go Tip workflow#7716
yurishkuro merged 7 commits into
jaegertracing:mainfrom
chinmay3012:#7664

chinmay3012 commented Dec 8, 2025 •

edited

Loading

Uh oh!

yurishkuro left a comment

Uh oh!

chinmay3012 commented Dec 8, 2025

Uh oh!

Uh oh!

yurishkuro commented Dec 8, 2025

Uh oh!

yurishkuro commented Dec 8, 2025

Uh oh!

Uh oh!

Uh oh!

yurishkuro commented Dec 8, 2025

Uh oh!

github-actions Bot commented Dec 8, 2025

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

🆕 Added Metrics

Uh oh!

chinmay3012 commented Dec 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

chinmay3012 commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Which problem is this PR solving?

Description of the changes

How was this change tested?

Uh oh!

yurishkuro left a comment

Choose a reason for hiding this comment

Uh oh!

chinmay3012 commented Dec 8, 2025

Uh oh!

Uh oh!

yurishkuro commented Dec 8, 2025

Uh oh!

yurishkuro commented Dec 8, 2025

Uh oh!

Uh oh!

Uh oh!

yurishkuro commented Dec 8, 2025

Uh oh!

github-actions Bot commented Dec 8, 2025

Metrics Comparison Summary

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

🆕 Added Metrics

Uh oh!

chinmay3012 commented Dec 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chinmay3012 commented Dec 8, 2025 •

edited

Loading