Skip to content

Remove v1 storage factories#7708

Merged
yurishkuro merged 4 commits into
jaegertracing:mainfrom
yurishkuro:remove-v1-storage-factories
Dec 7, 2025
Merged

Remove v1 storage factories#7708
yurishkuro merged 4 commits into
jaegertracing:mainfrom
yurishkuro:remove-v1-storage-factories

Conversation

@yurishkuro
Copy link
Copy Markdown
Member

@yurishkuro yurishkuro commented Dec 7, 2025

Now that v1 binaries are removed and remote-storage upgraded to share config with v2 storage extension we can remove v1 style factories and their CLI-based configuration methods

@yurishkuro yurishkuro requested a review from a team as a code owner December 7, 2025 16:10
@yurishkuro yurishkuro added the changelog:refactoring Internal code refactoring without functional changes label Dec 7, 2025
@dosubot dosubot Bot added the area/storage label Dec 7, 2025
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro force-pushed the remove-v1-storage-factories branch from e4889c2 to 0ea2ac3 Compare December 7, 2025 17:56
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.42%. Comparing base (48d374c) to head (0ea2ac3).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7708      +/-   ##
==========================================
+ Coverage   96.39%   96.42%   +0.03%     
==========================================
  Files         330      320      -10     
  Lines       17106    16569     -537     
==========================================
- Hits        16489    15977     -512     
+ Misses        463      442      -21     
+ Partials      154      150       -4     
Flag Coverage Δ
badger_v1 8.99% <ø> (+0.54%) ⬆️
badger_v2 1.89% <ø> (+0.10%) ⬆️
cassandra-4.x-v1-manual 12.79% <ø> (+0.78%) ⬆️
cassandra-4.x-v2-auto 1.88% <ø> (+0.10%) ⬆️
cassandra-4.x-v2-manual 1.88% <ø> (+0.10%) ⬆️
cassandra-5.x-v1-manual 12.79% <ø> (+0.78%) ⬆️
cassandra-5.x-v2-auto 1.88% <ø> (+0.10%) ⬆️
cassandra-5.x-v2-manual 1.88% <ø> (+0.10%) ⬆️
clickhouse 1.81% <ø> (+0.10%) ⬆️
elasticsearch-6.x-v1 17.07% <ø> (+1.04%) ⬆️
elasticsearch-7.x-v1 17.10% <ø> (+1.04%) ⬆️
elasticsearch-8.x-v1 17.25% <ø> (+1.05%) ⬆️
elasticsearch-8.x-v2 1.89% <ø> (+0.10%) ⬆️
elasticsearch-9.x-v2 1.89% <ø> (+0.10%) ⬆️
grpc_v1 8.80% <ø> (-1.54%) ⬇️
grpc_v2 1.89% <ø> (+0.10%) ⬆️
kafka-3.x-v2 1.89% <ø> (+0.10%) ⬆️
memory_v2 1.89% <ø> (+0.10%) ⬆️
opensearch-1.x-v1 17.14% <ø> (+1.04%) ⬆️
opensearch-2.x-v1 17.14% <ø> (+1.04%) ⬆️
opensearch-2.x-v2 1.89% <ø> (+0.10%) ⬆️
opensearch-3.x-v2 1.89% <ø> (+0.10%) ⬆️
query 1.89% <ø> (+0.10%) ⬆️
tailsampling-processor 0.54% <ø> (+0.03%) ⬆️
unittests 95.26% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro yurishkuro merged commit 898dfce into jaegertracing:main Dec 7, 2025
63 of 64 checks passed
@yurishkuro yurishkuro deleted the remove-v1-storage-factories branch December 7, 2025 18:33
SoumyaRaikwar pushed a commit to SoumyaRaikwar/jaeger that referenced this pull request Dec 18, 2025
Now that v1 binaries are removed and remote-storage upgraded to share
config with v2 storage extension we can remove v1 style factories and
their CLI-based configuration methods

---------

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: SoumyaRaikwar <somuraik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/storage changelog:refactoring Internal code refactoring without functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants