fix: Register basicauth extension in component factory#7668
Merged
Conversation
Signed-off-by: Snowiee <xenonoxidee@gmail.com>
yurishkuro
approved these changes
Nov 25, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7668 +/- ##
==========================================
+ Coverage 96.53% 96.56% +0.03%
==========================================
Files 384 384
Lines 19501 19502 +1
==========================================
+ Hits 18825 18832 +7
+ Misses 490 486 -4
+ Partials 186 184 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
via the queue into
jaegertracing:main
with commit Nov 25, 2025
fbf3ccc
64 of 65 checks passed
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Dec 3, 2025
Prepare release v1.76.0 / v2.13.0 ## Changes - Update CHANGELOG.md with v1.76.0 / v2.13.0 changes - Update jaeger-ui submodule to v1.76.0 - Rotate release managers (move @joe-elliott to bottom) ## Backend Changes - Fix: register basicauth extension in component factory (#7668) - CI improvements ## UI Changes See full list in CHANGELOG.md, including: - Dark theme selector - Fuzzy search for searchable select - Various bug fixes and UI improvements Signed-off-by: Joe Elliott <number101010@gmail.com>
SoumyaRaikwar
pushed a commit
to SoumyaRaikwar/jaeger
that referenced
this pull request
Dec 18, 2025
…#7668) ## Which problem is this PR solving? * jaegertracing#7656 ## Problem The basicauth extension from opentelemetry-collector-contrib was not registered in Jaeger's component factory, causing "unknown type: basicauth" errors when users tried to configure it for Prometheus authentication with TLS + basic auth. ## Description of the changes - Registered `basicauth` extension from opentelemetry-collector-contrib in the component factory - Added import for `basicauthextension` package in `cmd/jaeger/internal/components.go` - Added `basicauthextension.NewFactory()` to the extensions list to make it available for authentication configurations ## How was this change tested? - Built the project successfully with the new extension registered - Created a test configuration with `basicauth/prometheus_client` extension - Verified Jaeger starts without "unknown type: basicauth" error - Confirmed the extension loads and starts successfully in the logs ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: Snowiee <xenonoxidee@gmail.com> Signed-off-by: SoumyaRaikwar <somuraik@gmail.com>
SoumyaRaikwar
pushed a commit
to SoumyaRaikwar/jaeger
that referenced
this pull request
Dec 18, 2025
Prepare release v1.76.0 / v2.13.0 ## Changes - Update CHANGELOG.md with v1.76.0 / v2.13.0 changes - Update jaeger-ui submodule to v1.76.0 - Rotate release managers (move @joe-elliott to bottom) ## Backend Changes - Fix: register basicauth extension in component factory (jaegertracing#7668) - CI improvements ## UI Changes See full list in CHANGELOG.md, including: - Dark theme selector - Fuzzy search for searchable select - Various bug fixes and UI improvements Signed-off-by: Joe Elliott <number101010@gmail.com> Signed-off-by: SoumyaRaikwar <somuraik@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Problem
The basicauth extension from opentelemetry-collector-contrib was not registered in Jaeger's component factory, causing
"unknown type: basicauth" errors when users tried to configure it for Prometheus authentication with TLS + basic auth.
Description of the changes
basicauthextension from opentelemetry-collector-contrib in the component factorybasicauthextensionpackage incmd/jaeger/internal/components.gobasicauthextension.NewFactory()to the extensions list to make it available for authentication configurationsHow was this change tested?
basicauth/prometheus_clientextensionChecklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test