Update jaeger-ui submodule with fetchOpsMetricsDone fix #7623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update jaeger-ui submodule to include the fix for TypeError when metrics is undefined, preventing UI crashes when querying services with no trace data. Fixes jaegertracing#7423 Signed-off-by: ADITYATIWARI342005 <[email protected]>
Signed-off-by: ADITYA TIWARI <[email protected]>
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| @@ -1 +1 @@ | |||
| Subproject commit 4606e0e7aba353224c0a7d1d2588366da3993f24 | |||
| Subproject commit 958037870bba9f3ad0825d3a1d1d1cd2c934aefe | |||
There was a problem hiding this comment.
There appears to be a discrepancy between the commit hash in the code change (958037870bba9f3ad0825d3a1d1d1cd2c934aefe) and the one referenced in the PR description (82ef7a4).
Please verify that the correct commit is being referenced to ensure the PR includes the intended fix for the TypeError in fetchOpsMetricsDone. This verification is important to confirm that the actual changes match what's described in the PR.
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
Submodule commits included:
82ef7a4- Fix TypeError with defensive null check95803787- Apply prettier formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
Update
jaeger-uisubmodule reference to include the fix for TypeError infetchOpsMetricsDonewhenmetric.metricsis undefined.Related PR: [[jaeger-ui#3130)] - Fix TypeError in fetchOpsMetricsDone when metrics is undefined
Submodule commits included:
82ef7a4- Fix TypeError with defensive null check95803787- Apply prettier formattingWhat this updates:
jaeger-uiupdated from4606e0eto82ef7a4Impact: Users can now query services with no traces without encountering crashes or infinite loading states.
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test