test: improve test coverage for shutdown scenarios #7621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive test cases for previously uncovered shutdown code paths: - TestShutdownWithDistributedLockError: validates shutdown with nil distributed lock - TestShutdownWithGRPCServer: tests shutdown with active gRPC server - TestShutdownWithAllComponents: tests shutdown with multiple active components - TestShutdownWithNilComponents: tests shutdown when all components are nil Signed-off-by: ADITYATIWARI342005 <[email protected]>
…vior The test comment incorrectly stated it tests 'when distributed lock fails to close', but the test actually validates shutdown behavior when the distributed lock is nil (which should not cause an error). Updated the comment to accurately describe the test's purpose. Signed-off-by: ADITYATIWARI342005 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
remotesamplingextension'sShutdownmethodTestShutdownWithNilDistributedLock- tests shutdown when distributed lock is nilTestShutdownWithGRPCServer- tests shutdown with active gRPC serverTestShutdownWithAllComponents- tests shutdown with multiple active components (strategy provider, HTTP server, gRPC server)TestShutdownWithNilComponents- tests shutdown when all components are nilShutdownimplementation already correctly useserrors.Join()to append errors as recommended in the issueNote: This PR provides partial coverage for #7432. Additional tests for Start method error paths and other uncovered lines can be added in follow-up PRs.
How was this change tested?
go test ./cmd/jaeger/internal/extension/remotesampling/... -vmake lint test- no linting errorsChecklist
jaeger:make lint test