feat(query/v2): add max-trace-size limit with early termination to prevent OOM #7527

ADITYATIWARI342005 · 2025-09-30T07:46:16Z

Which problem is this PR solving?

Resolves [Feature]: Implement max trace size parameter in the query service #7495
Related to Jaeger Query can OOM when retrieving large traces #1051 (OOM with large traces)

Description of the changes

Adds max_trace_size parameter to v2 query service with early termination when limit is reached, preventing OOM on large traces.

Key changes:

V1TracesFromSeq2 now accepts explicit maxTraceSize int parameter
Incremental span counting with early iterator termination when limit exceeded
applyTraceSizeLimit helper truncates traces and logs warnings
Limit threaded through v2 adapter (0 = unlimited)
v2-only; no v1 changes

Modified files:

internal/storage/v2/v1adapter/translator.go - limiting logic
internal/storage/v2/v1adapter/translator_test.go - test coverage
internal/storage/v2/v1adapter/{tracereader,spanreader}.go - parameter wiring
Call sites updated to pass 0 (unlimited)

How was this change tested?

Unit tests for unlimited mode and truncation scenarios
go test ./internal/storage/v2/v1adapter -count=1 passes
Manual verification with traces exceeding limit

Checklist

I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
I have signed all commits
I have added unit tests for the new functionality
I have run lint and test steps successfully

…early termination Signed-off-by: ADITYATIWARI342005 <[email protected]>

ADITYATIWARI342005 · 2025-09-30T07:49:57Z

Hi @yurishkuro @AnmolxSingh
Thank you for your reviews on the PR #7499 , I realized it was overly complicated and inefficient.
therefore I closed it.

This PR is optimal and addresses the issue #7495 completely.

Please review it.
Thank you.

…n in translator Signed-off-by: ADITYATIWARI342005 <[email protected]>

codecov · 2025-10-04T18:54:30Z

Codecov Report

❌ Patch coverage is 91.89189% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.48%. Comparing base (f135545) to head (82ea91b).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/storage/v2/v1adapter/translator.go	90.42%	6 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7527      +/-   ##
==========================================
- Coverage   96.50%   96.48%   -0.03%     
==========================================
  Files         385      385              
  Lines       23316    23422     +106     
==========================================
+ Hits        22501    22598      +97     
- Misses        627      633       +6     
- Partials      188      191       +3

Flag	Coverage Δ
badger_v1	`8.94% <0.00%> (-0.08%)`	⬇️
badger_v2	`1.58% <0.00%> (-0.02%)`	⬇️
cassandra-4.x-v1-manual	`11.57% <0.00%> (-0.10%)`	⬇️
cassandra-4.x-v2-auto	`1.57% <0.00%> (-0.02%)`	⬇️
cassandra-4.x-v2-manual	`1.57% <0.00%> (-0.02%)`	⬇️
cassandra-5.x-v1-manual	`11.57% <0.00%> (-0.10%)`	⬇️
cassandra-5.x-v2-auto	`1.57% <0.00%> (-0.02%)`	⬇️
cassandra-5.x-v2-manual	`1.57% <0.00%> (-0.02%)`	⬇️
clickhouse	`1.52% <0.00%> (-0.02%)`	⬇️
elasticsearch-6.x-v1	`16.42% <0.00%> (-0.15%)`	⬇️
elasticsearch-7.x-v1	`16.46% <0.00%> (-0.15%)`	⬇️
elasticsearch-8.x-v1	`16.60% <0.00%> (-0.15%)`	⬇️
elasticsearch-8.x-v2	`1.58% <0.00%> (-0.02%)`	⬇️
elasticsearch-9.x-v2	`1.58% <0.00%> (-0.02%)`	⬇️
grpc_v1	`10.14% <2.00%> (-0.07%)`	⬇️
grpc_v2	`1.58% <0.00%> (-0.02%)`	⬇️
kafka-3.x-v1	`9.58% <0.00%> (-0.09%)`	⬇️
kafka-3.x-v2	`1.58% <0.00%> (-0.02%)`	⬇️
memory_v2	`1.58% <0.00%> (-0.02%)`	⬇️
opensearch-1.x-v1	`16.51% <0.00%> (-0.15%)`	⬇️
opensearch-2.x-v1	`16.51% <0.00%> (-0.15%)`	⬇️
opensearch-2.x-v2	`1.58% <0.00%> (-0.02%)`	⬇️
opensearch-3.x-v2	`1.58% <0.00%> (-0.02%)`	⬇️
query	`1.58% <0.00%> (-0.02%)`	⬇️
tailsampling-processor	`0.43% <0.00%> (-0.01%)`	⬇️
unittests	`95.48% <91.89%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-10-04T18:56:03Z

Metrics Comparison Summary

Total changes across all snapshots: 53

Detailed changes per snapshot

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

Total Changes: 53

🆕 Added: 53 metrics
❌ Removed: 0 metrics
🔄 Modified: 0 metrics

🆕 Added Metrics

http_server_request_body_size_bytes (18 variants)

View diff sample

+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

- `http_server_request_duration_seconds` (17 variants)

View diff sample

+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.005",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.01",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.025",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.05",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.075",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.1",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

- `http_server_response_body_size_bytes` (18 variants)

View diff sample

+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

➡️ View full metrics file

ADITYATIWARI342005 · 2025-10-04T19:31:38Z

@yurishkuro
Sorry to bother you, But could you please add a label to this Pull Request to pass the CI checks.
Also, Please tell me how should I improve Codecov score.

cmd/query/app/flags.go

internal/storage/integration/integration.go

Add configurable trace size limiting to prevent OOM issues when retrieving large traces. Implements early termination with proper iterator stopping, comprehensive unit tests, and full configuration wiring through v1/v2 query services and jaeger extension. Addresses maintainer feedback by preserving original function signatures and adding validation tests. Signed-off-by: ADITYATIWARI342005 <[email protected]>

internal/storage/v2/v1adapter/translator.go

Fix critical bug where truncated traces would prevent processing of subsequent traces in the same sequence. Now properly resets truncated state when a new trace ID is detected, allowing multiple traces to be processed correctly even when some exceed the size limit. Signed-off-by: ADITYATIWARI342005 <[email protected]>

internal/storage/v2/v1adapter/translator_test.go

…ot review on the test Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> Signed-off-by: ADITYA TIWARI <[email protected]>

Add tests to cover edge cases in applyTraceSizeLimit: - Error handling in sequence processing - Truncated trace continuation across multiple chunks - Multiple traces where some exceed limit while others are processed These tests ensure the max-trace-size feature works correctly in all scenarios." Signed-off-by: ADITYA TIWARI <[email protected]>

ADITYATIWARI342005 · 2025-10-05T03:50:07Z

@yurishkuro
I have added tests to fulfill Codecov report, This pull request is now ready for review,
Please review it.

internal/storage/v2/v1adapter/translator.go

- Remove redundant V1TracesFromSeq2WithLimit function - Merge limiting logic into V1TracesFromSeq2 with maxTraceSize parameter - Fix trace boundary detection with proper getFirstTraceID helper - Optimize to single-pass processing instead of multiple loops - Update all call sites to use unified API Signed-off-by: ADITYATIWARI342005 <[email protected]>

…undant logic) + Created single helper: extractTraceIDAndCount() - does both operations in one loop Signed-off-by: ADITYATIWARI342005 <[email protected]>

…ds repetition \n Core truncation scenarios covered No duplication with existing tests Less code to maintain Signed-off-by: ADITYATIWARI342005 <[email protected]>

ADITYATIWARI342005 · 2025-10-26T08:16:54Z

Hi @yurishkuro ,
I have resolved all the issues from the previous review, and I have modified the test file to remove duplication with the existing tests, & I have tested the code locally.
I think the implementation is now optimal and ready for review,
Please review and suggest improvements,

Thank you for your guidance and efforts so far!

feat(query/v2): enforce max-trace-size with incremental limiting and …

5d0612f

…early termination Signed-off-by: ADITYATIWARI342005 <[email protected]>

ADITYATIWARI342005 requested a review from a team as a code owner September 30, 2025 07:46

ADITYATIWARI342005 requested a review from pavolloffay September 30, 2025 07:46

dosubot bot added area/storage v2 labels Sep 30, 2025

ADITYATIWARI342005 changed the title ~~feat(query/v2): enforce max-trace-size with incremental limiting and …~~ feat: add max-trace-size limit with early termination to prevent OOM Sep 30, 2025

ADITYATIWARI342005 changed the title ~~feat: add max-trace-size limit with early termination to prevent OOM~~ feat(query/v2): add max-trace-size limit with early termination to prevent OOM Sep 30, 2025

feat(query/v2): wire max-trace-size and enforce with early terminatio…

ef4f6bc

…n in translator Signed-off-by: ADITYATIWARI342005 <[email protected]>

yurishkuro reviewed Oct 4, 2025

View reviewed changes

cmd/query/app/flags.go Show resolved Hide resolved

yurishkuro reviewed Oct 4, 2025

View reviewed changes

internal/storage/integration/integration.go Show resolved Hide resolved

graphite-app bot reviewed Oct 4, 2025

View reviewed changes

internal/storage/v2/v1adapter/translator.go Show resolved Hide resolved

graphite-app bot reviewed Oct 4, 2025

View reviewed changes

internal/storage/v2/v1adapter/translator_test.go Show resolved Hide resolved

Update internal/storage/v2/v1adapter/translator_test.go, from valid b…

1970982

…ot review on the test Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> Signed-off-by: ADITYA TIWARI <[email protected]>

ADITYATIWARI342005 requested a review from yurishkuro October 4, 2025 20:59

ADITYATIWARI342005 added 3 commits October 5, 2025 02:29

Merge branch 'main' into feature/max-trace-size-clean

82ea91b

Merge branch 'main' into feature/max-trace-size-clean

e29b8ca

Merge branch 'main' into feature/max-trace-size-clean

7cdad9c

yurishkuro reviewed Oct 25, 2025

View reviewed changes

internal/storage/v2/v1adapter/translator.go Outdated Show resolved Hide resolved

yurishkuro reviewed Oct 25, 2025

View reviewed changes

internal/storage/v2/v1adapter/translator.go Outdated Show resolved Hide resolved

yurishkuro reviewed Oct 25, 2025

View reviewed changes

internal/storage/v2/v1adapter/translator.go Outdated Show resolved Hide resolved

ADITYATIWARI342005 added 2 commits October 26, 2025 12:09

removed 3 separate functions (getFirstTraceID, countSpansInTrace, red…

4335e71

…undant logic) + Created single helper: extractTraceIDAndCount() - does both operations in one loop Signed-off-by: ADITYATIWARI342005 <[email protected]>

ADITYATIWARI342005 requested a review from yurishkuro October 26, 2025 07:59

ADITYATIWARI342005 added 2 commits October 26, 2025 13:41

test file is now focused on the max-trace-size functionality and avoi…

27d7dac

…ds repetition \n Core truncation scenarios covered No duplication with existing tests Less code to maintain Signed-off-by: ADITYATIWARI342005 <[email protected]>

Merge branch 'main' into feature/max-trace-size-clean

1a863b4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(query/v2): add max-trace-size limit with early termination to prevent OOM #7527

feat(query/v2): add max-trace-size limit with early termination to prevent OOM #7527

Uh oh!

ADITYATIWARI342005 commented Sep 30, 2025 •

edited

Loading

Uh oh!

ADITYATIWARI342005 commented Sep 30, 2025

Uh oh!

codecov bot commented Oct 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 4, 2025 •

edited

Loading

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

🆕 Added Metrics

Uh oh!

ADITYATIWARI342005 commented Oct 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ADITYATIWARI342005 commented Oct 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ADITYATIWARI342005 commented Oct 26, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(query/v2): add max-trace-size limit with early termination to prevent OOM #7527

Are you sure you want to change the base?

feat(query/v2): add max-trace-size limit with early termination to prevent OOM #7527

Uh oh!

Conversation

ADITYATIWARI342005 commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

Uh oh!

ADITYATIWARI342005 commented Sep 30, 2025

Uh oh!

codecov bot commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Metrics Comparison Summary

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

🆕 Added Metrics

Uh oh!

ADITYATIWARI342005 commented Oct 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ADITYATIWARI342005 commented Oct 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ADITYATIWARI342005 commented Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ADITYATIWARI342005 commented Sep 30, 2025 •

edited

Loading

codecov bot commented Oct 4, 2025 •

edited

Loading

github-actions bot commented Oct 4, 2025 •

edited

Loading

ADITYATIWARI342005 commented Oct 26, 2025 •

edited

Loading