Skip to content

Conversation

@mahadzaryab1
Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 commented Nov 16, 2024

Description of the changes

  • The SPM integration test in the CI has been failing consistently. It looks like the default endpoint for prometheus has changed from localhost:9090/graph to localhost:9090/query. This PR fixes that in the integration test and in the README.

How was this change tested?

  • Integration test passes
  • Ran the docker-compose/monitor/docker-compose-v2.yml example and verified that the prometheus UI displays the metrics at the new endpoint.
Screenshot 2024-11-16 at 1 44 55 PM

Checklist

@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review November 16, 2024 18:45
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner November 16, 2024 18:45
@mahadzaryab1 mahadzaryab1 added the changelog:ci Change related to continuous integration / testing label Nov 16, 2024
@codecov
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (eb6c5c9) to head (9dfa00f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6217   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         354      354           
  Lines       20127    20127           
=======================================
  Hits        19418    19418           
  Misses        524      524           
  Partials      185      185           
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.60% <ø> (ø)
elasticsearch-7.x-v1 18.68% <ø> (ø)
elasticsearch-8.x-v1 18.84% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v2 1.67% <ø> (ø)
grpc_v1 9.47% <ø> (-0.01%) ⬇️
grpc_v2 7.00% <ø> (+<0.01%) ⬆️
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <ø> (ø)
memory_v2 1.67% <ø> (ø)
opensearch-1.x-v1 18.72% <ø> (ø)
opensearch-2.x-v1 18.72% <ø> (-0.01%) ⬇️
opensearch-2.x-v2 1.67% <ø> (ø)
tailsampling-processor 0.46% <ø> (ø)
unittests 95.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 6585c6e into jaegertracing:main Nov 16, 2024
52 checks passed
@yurishkuro
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:ci Change related to continuous integration / testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants