Skip to content

Require manual Go version updates for patch versions #5848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Require manual Go version updates for patch versions #5848

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc5783e
updated script for manual patch check
wasup-yash Aug 14, 2024
098e386
remove the docker func
wasup-yash Aug 15, 2024
eb52519
removed docker func
wasup-yash Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion scripts/check-go-version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,11 @@ function check() {
fi

if [[ $update = true && "$mismatch" != "" ]]; then
# Detect if the line includes a patch version
if [[ "$go_version" =~ $version_regex\.[0-9]+ ]]; then
echo "Patch version detected in $file. Manual update required."
exit 1
fi
update "$file" "$pattern" "$go_version" "$target"
mismatch="*** => $target ***"
fi
Expand All @@ -78,7 +83,6 @@ function check() {

check go.mod "^go\s\+$version_regex" "$go_previous_version"
check internal/tools/go.mod "^go\s\+$version_regex" "$go_latest_version"

check docker/debug/Dockerfile "^.*golang:$version_regex" "$go_latest_version"

IFS='|' read -r -a gha_workflows <<< "$(grep -rl go-version .github | tr '\n' '|')"
Expand Down