Skip to content

Conversation

@joeyyy09
Copy link
Member

@joeyyy09 joeyyy09 commented Jul 3, 2024

Which problem is this PR solving?

Description of the changes

  • Add config files for replacement of jaeger-collector and jaeger-ingester.
  • Add the architecture for the integration tests for kafka.
  • Add e2e integration tests for Kafka.

How was this change tested?

  • Manually ran the collector, ingester configs to check if the data is being pushed and pulled the right way and verified the architecture.

Checklist

@codecov
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.66%. Comparing base (d8b2110) to head (d7c70cf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5703      +/-   ##
==========================================
+ Coverage   96.65%   96.66%   +0.01%     
==========================================
  Files         342      342              
  Lines       16515    16515              
==========================================
+ Hits        15962    15964       +2     
+ Misses        363      362       -1     
+ Partials      190      189       -1     
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.81% <ø> (ø)
cassandra-3.x-v1 16.61% <ø> (ø)
cassandra-3.x-v2 1.74% <ø> (ø)
cassandra-4.x-v1 16.61% <ø> (ø)
cassandra-4.x-v2 1.74% <ø> (ø)
elasticsearch-6.x-v1 18.77% <ø> (-0.02%) ⬇️
elasticsearch-7.x-v1 18.83% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v1 19.02% <ø> (ø)
elasticsearch-8.x-v2 1.81% <ø> (?)
grpc_v1 9.52% <ø> (ø)
grpc_v2 7.14% <ø> (ø)
kafka 9.74% <ø> (ø)
memory_v2 1.81% <ø> (ø)
opensearch-1.x-v1 18.89% <ø> (ø)
opensearch-2.x-v1 18.88% <ø> (-0.02%) ⬇️
opensearch-2.x-v2 1.81% <ø> (ø)
unittests 95.08% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but we need e2e tests

@yurishkuro yurishkuro added storage/kafka v2 changelog:exprimental Change to an experimental part of the code labels Jul 3, 2024
@joeyyy09
Copy link
Member Author

joeyyy09 commented Jul 4, 2024

Lgtm, but we need e2e tests

Yeah, will get started on it!

joeyyy09 added 2 commits July 16, 2024 11:07
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
joeyyy09 added 2 commits July 18, 2024 21:14
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Harshith Mente <[email protected]>
joeyyy09 added 2 commits July 19, 2024 16:35
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
joeyyy09 added 4 commits July 20, 2024 22:44
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to add this new test to the gh workflow? I don't see how it's getting run now.

@joeyyy09
Copy link
Member Author

Do you need to add this new test to the gh workflow? I don't see how it's getting run now.

Yes, I'll be doing that

joeyyy09 added 2 commits July 24, 2024 14:09
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@yurishkuro yurishkuro marked this pull request as ready for review July 24, 2024 20:10
@yurishkuro yurishkuro requested a review from a team as a code owner July 24, 2024 20:10
@yurishkuro yurishkuro requested a review from albertteoh July 24, 2024 20:10
@dosubot dosubot bot added the enhancement label Jul 24, 2024
@yurishkuro
Copy link
Member

I think we should merge this is the build is green. It's not running the e2e test, but we can add that in a separate PR.

@yurishkuro yurishkuro enabled auto-merge (squash) July 24, 2024 20:11
@yurishkuro yurishkuro merged commit e437971 into jaegertracing:main Jul 24, 2024
@joeyyy09
Copy link
Member Author

I think we should merge this is the build is green. It's not running the e2e test, but we can add that in a separate PR.

Yeah sure, i'll open another PR for the e2e test

@joeyyy09 joeyyy09 deleted the kafka-config branch July 29, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:exprimental Change to an experimental part of the code enhancement storage/kafka v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Jaeger v2] Add Kafka exporter and receiver

2 participants