-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Enable SPM in Jaeger v2 #5681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Enable SPM in Jaeger v2 #5681
Changes from 4 commits
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
6ed4f23
Create setup for enabling SPM in v2
FlamingSaint dc85461
Add connector to the config and add suggested changes to the Makefile
FlamingSaint e5d9850
Add integration test for SPM v2
FlamingSaint 1bf0ece
fix
FlamingSaint 8ba9818
Add suggested changes
FlamingSaint 6f61680
Add suggested changes
FlamingSaint ff42224
fix CI
FlamingSaint 0dbda14
Add changes
FlamingSaint 591fda9
fix
FlamingSaint 31ffea5
Add quotes
FlamingSaint ea0d5ec
Fix CI
FlamingSaint fb4b0ce
Add prometheusexporter to components.go
FlamingSaint 231e397
Merge branch 'main' into spm
FlamingSaint 6f42591
fix conflicts
FlamingSaint 0cb5f7a
Use microsim v0.4.1 in docker-compose-v2.yml
FlamingSaint 91987df
Added suggested changes and ran go mod tidy
FlamingSaint c49e322
Merge branch 'main' into spm
FlamingSaint 43b2e72
Add back the endpoint
FlamingSaint 5e9d0e4
Merge branch 'main' into spm
FlamingSaint 977c9d1
Merge branch 'main' into spm
FlamingSaint e926e8a
Merge branch 'jaegertracing:main' into spm
FlamingSaint 4ba0ad0
Add config for metrics_storage
FlamingSaint 5675055
Separate TracesBackend and MetricsBackend
FlamingSaint 6479836
Add suggested change
FlamingSaint 14b94fe
Initialize the metrics storage in extensions.go
FlamingSaint c986181
Use singular naming
FlamingSaint 5c5d701
fix naming
FlamingSaint 21ea847
Add config options for prometheus
FlamingSaint 1b6c9ca
Merge branch 'main' into spm
FlamingSaint 118c8fb
Merge branch 'main' into spm
FlamingSaint 44f2627
Resolve conflicts
FlamingSaint be42117
initialize metrics storage in extension.go
FlamingSaint c872291
Add changes
FlamingSaint 85442e8
fix
FlamingSaint 865d2ee
Add changes
FlamingSaint c6abf8b
WIP: Passed metric storage to the query service
FlamingSaint 21f66f9
Merge branch 'main' into spm
FlamingSaint fa04c99
Use telset.logger instead of logger
FlamingSaint 636191b
fix: generate mocks
FlamingSaint c39f8ec
Use Initialize instead of InitializeMetricsFactory
FlamingSaint f871540
Remove comments
FlamingSaint 78ca11f
fix
FlamingSaint ed90e30
add changes
FlamingSaint 7d4ee8e
resolve conflicts
FlamingSaint bae9e39
Merge branch 'main' into spm
FlamingSaint 90176e2
Simplify
yurishkuro 3a937b3
Simplify
yurishkuro f9bf6ba
Clean-up
yurishkuro 176c332
fix
yurishkuro 50e312c
Clean-up
yurishkuro f105bc9
fix
yurishkuro 0cdb5ca
Fixes
yurishkuro db32afe
missed the file
yurishkuro 2034502
Catch-all via wildcard
yurishkuro 9d2f9b2
DRY code, rename public methods to be more consistent
yurishkuro 4f87e23
Add changes
FlamingSaint 7da08f3
Merge branch 'main' into spm
FlamingSaint 0aefd7b
Increase code coverage
FlamingSaint 81bc142
fix lint
FlamingSaint 2e36abe
fix
FlamingSaint 060740b
Increase coverage
FlamingSaint 8f0ee2b
Increase coverage
FlamingSaint b17125a
Add changes
FlamingSaint f7a749e
fix
FlamingSaint 64afe89
Merge branch 'main' into spm
FlamingSaint 0301e64
fix
FlamingSaint 4c51ab2
Remove extra spaces
FlamingSaint 96649c9
Increase code coverage
FlamingSaint 032a860
Increase code cov
FlamingSaint 3ec5360
Increase code cov
FlamingSaint d641e36
Add changes
FlamingSaint File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| version: "3.5" | ||
| services: | ||
| jaeger: | ||
| networks: | ||
| - backend | ||
| image: jaegertracing/jaeger:${JAEGER_IMAGE_TAG:-latest} | ||
| volumes: | ||
| - "./jaeger-ui.json:/etc/jaeger/jaeger-ui.json" # Do we need this for v2 ? Seems to be running without this. | ||
| - "./jaeger-v2-config.yml:/etc/jaeger/jaeger-v2-config.yml" | ||
| command: ["--config", "/etc/jaeger/jaeger-v2-config.yml"] | ||
|
FlamingSaint marked this conversation as resolved.
Outdated
|
||
| environment: | ||
| - METRICS_STORAGE_TYPE=prometheus | ||
|
FlamingSaint marked this conversation as resolved.
Outdated
|
||
| - PROMETHEUS_SERVER_URL=http://prometheus:9090 | ||
| # - PROMETHEUS_QUERY_SUPPORT_SPANMETRICS_CONNECTOR=${PROMETHEUS_QUERY_SUPPORT_SPANMETRICS_CONNECTOR:-true} | ||
| - PROMETHEUS_QUERY_NAMESPACE=${PROMETHEUS_QUERY_NAMESPACE:-} | ||
| - PROMETHEUS_QUERY_DURATION_UNIT=${PROMETHEUS_QUERY_DURATION_UNIT:-} | ||
| - PROMETHEUS_QUERY_NORMALIZE_CALLS=true | ||
| - PROMETHEUS_QUERY_NORMALIZE_DURATION=true | ||
| ports: | ||
| - "16686:16686" | ||
| - "14278:14278" | ||
| microsim: | ||
| networks: | ||
| - backend | ||
| image: yurishkuro/microsim:0.3.0 | ||
| # TODO: Fix error - dial tcp [::1]:14278: connect: connection refused | ||
| command: "-j http://localhost:14278/api/traces -d 24h -s 500ms" | ||
| depends_on: | ||
| - jaeger | ||
| prometheus: | ||
| networks: | ||
| - backend | ||
| image: prom/prometheus:latest | ||
| volumes: | ||
| - "./prometheus.yml:/etc/prometheus/prometheus.yml" | ||
| ports: | ||
| - "9090:9090" | ||
| grafana: | ||
| networks: | ||
| - backend | ||
| image: grafana/grafana:latest | ||
| volumes: | ||
| - ./grafana.ini:/etc/grafana/grafana.ini | ||
| - ./datasource.yml:/etc/grafana/provisioning/datasources/datasource.yaml | ||
| environment: | ||
| - GF_AUTH_ANONYMOUS_ENABLED=true | ||
| - GF_AUTH_ANONYMOUS_ORG_ROLE=Admin | ||
| - GF_AUTH_DISABLE_LOGIN_FORM=true | ||
| ports: | ||
| - 3000:3000 | ||
|
|
||
| networks: | ||
| backend: | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| service: | ||
|
FlamingSaint marked this conversation as resolved.
|
||
| extensions: [jaeger_storage, jaeger_query] | ||
| pipelines: | ||
| traces: | ||
| receivers: [otlp, jaeger, zipkin] | ||
| processors: [batch] | ||
| exporters: [jaeger_storage_exporter, spanmetrics] | ||
| metrics/spanmetrics: | ||
| receivers: [spanmetrics] | ||
| exporters: [prometheus] | ||
|
|
||
|
|
||
| extensions: | ||
| jaeger_query: | ||
| trace_storage: memstore | ||
|
|
||
| jaeger_storage: | ||
| memory: | ||
| memstore: | ||
| max_traces: 100000 | ||
|
|
||
| connectors: | ||
| spanmetrics: | ||
|
|
||
| receivers: | ||
| otlp: | ||
| protocols: | ||
| grpc: | ||
| http: | ||
|
|
||
| jaeger: | ||
|
FlamingSaint marked this conversation as resolved.
Outdated
|
||
| protocols: | ||
| grpc: | ||
| thrift_binary: | ||
| thrift_compact: | ||
| thrift_http: | ||
|
FlamingSaint marked this conversation as resolved.
Outdated
|
||
|
|
||
| zipkin: | ||
|
FlamingSaint marked this conversation as resolved.
Outdated
|
||
|
|
||
| processors: | ||
| batch: | ||
|
|
||
| exporters: | ||
| jaeger_storage_exporter: | ||
| trace_storage: memstore | ||
| prometheus: | ||
| endpoint: "0.0.0.0:8889" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.