Skip to content

Conversation

@yurishkuro
Copy link
Member

Which problem is this PR solving?

  • It turns out by default the Renovate bot does not run go mod tidy, so it leaves unused entries in the go.mod/sum files.

Description of the changes

  • Enable both tidy and upgrading imports on major version changes

How was this change tested?

  • CI

@yurishkuro yurishkuro requested a review from a team as a code owner June 12, 2024 23:39
@yurishkuro yurishkuro requested a review from jkowall June 12, 2024 23:39
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jun 12, 2024
@codecov
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (7fab03b) to head (36a54fd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5612   +/-   ##
=======================================
  Coverage   96.19%   96.19%           
=======================================
  Files         327      327           
  Lines       16013    16013           
=======================================
  Hits        15403    15403           
  Misses        433      433           
  Partials      177      177           
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.93% <ø> (ø)
cassandra-3.x-v1 16.45% <ø> (ø)
cassandra-3.x-v2 1.85% <ø> (ø)
cassandra-4.x-v1 16.45% <ø> (ø)
cassandra-4.x-v2 1.85% <ø> (ø)
elasticsearch-7.x-v1 18.88% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v1 19.09% <ø> (ø)
elasticsearch-8.x-v2 19.09% <ø> (ø)
grpc_v1 9.48% <ø> (ø)
grpc_v2 7.53% <ø> (ø)
kafka 9.77% <ø> (ø)
opensearch-1.x-v1 18.94% <ø> (+0.01%) ⬆️
opensearch-2.x-v1 18.94% <ø> (ø)
opensearch-2.x-v2 18.93% <ø> (-0.02%) ⬇️
unittests 94.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@yurishkuro yurishkuro merged commit af2638e into jaegertracing:main Jun 13, 2024
@yurishkuro yurishkuro deleted the renovate-tidy branch June 13, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:ci Change related to continuous integration / testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants