Skip to content

Conversation

@hellspawn679
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • changing how major version is passed eg form 7.x -> 7

How was this change tested?

Checklist

@hellspawn679 hellspawn679 requested a review from a team as a code owner June 9, 2024 18:33
@hellspawn679 hellspawn679 requested a review from joe-elliott June 9, 2024 18:33
@codecov
Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.20%. Comparing base (3d4b6b6) to head (b792c81).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5546      +/-   ##
==========================================
- Coverage   96.21%   96.20%   -0.02%     
==========================================
  Files         327      327              
  Lines       16021    16021              
==========================================
- Hits        15415    15413       -2     
- Misses        431      432       +1     
- Partials      175      176       +1     
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.93% <ø> (ø)
cassandra-3.x-v1 16.45% <ø> (ø)
cassandra-3.x-v2 1.85% <ø> (ø)
cassandra-4.x-v1 16.45% <ø> (ø)
cassandra-4.x-v2 1.85% <ø> (ø)
elasticsearch-7-v1 ?
elasticsearch-7.x-v1 18.88% <ø> (?)
elasticsearch-8-v1 ?
elasticsearch-8-v2 ?
elasticsearch-8.x-v1 19.07% <ø> (?)
elasticsearch-8.x-v2 19.09% <ø> (?)
grpc_v1 9.48% <ø> (ø)
grpc_v2 7.53% <ø> (ø)
kafka 9.77% <ø> (ø)
opensearch-1-v1 ?
opensearch-1.x-v1 18.93% <ø> (?)
opensearch-2-v1 ?
opensearch-2-v2 ?
opensearch-2.x-v1 18.93% <ø> (?)
opensearch-2.x-v2 18.94% <ø> (?)
unittests 94.08% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro
Copy link
Member

This is the opposite of what I wanted. The existing tests are called cassandra 4.x v1, with your change they are called cassandra 4 v1 - less readable (and because it's a matrix we don't seem to have control over naming).

Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: mehul gautam <[email protected]>
Signed-off-by: mehul gautam <[email protected]>
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jun 10, 2024
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro merged commit ac55dc0 into jaegertracing:main Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:ci Change related to continuous integration / testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants