Skip to content

Conversation

@varshith257
Copy link
Contributor

@varshith257 varshith257 commented May 18, 2024

Which problem is this PR solving?

Description of the changes

  • Updated codecov.yml threshold back to 95%

How was this change tested?

  • N/A

Checklist

@varshith257 varshith257 requested a review from a team as a code owner May 18, 2024 03:04
@varshith257 varshith257 requested a review from pavolloffay May 18, 2024 03:04
yurishkuro and others added 2 commits May 18, 2024 08:35
@varshith257 varshith257 changed the title updated codecov.yml Bring code coverage back to 95% May 18, 2024
Signed-off-by: Vamshi Maskuri <[email protected]>
Signed-off-by: Vamshi Maskuri <[email protected]>
@codecov
Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.46%. Comparing base (14cbcea) to head (79a783d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5457   +/-   ##
=======================================
  Coverage   95.46%   95.46%           
=======================================
  Files         331      331           
  Lines       16112    16112           
=======================================
  Hits        15382    15382           
  Misses        556      556           
  Partials      174      174           
Flag Coverage Δ
badger_v1 8.08% <ø> (ø)
badger_v2 1.94% <ø> (ø)
cassandra-3.x-v1 16.48% <ø> (ø)
cassandra-3.x-v2 ?
cassandra-4.x-v1 16.48% <ø> (ø)
cassandra-4.x-v2 1.86% <ø> (ø)
elasticsearch-7.x 1.78% <ø> (+0.01%) ⬆️
elasticsearch-8.x 1.77% <ø> (-0.02%) ⬇️
grpc_v1 9.10% <ø> (ø)
grpc_v2 7.49% <ø> (ø)
kafka 9.81% <ø> (ø)
opensearch-1.x 1.78% <ø> (+0.01%) ⬆️
opensearch-2.x 1.77% <ø> (-0.02%) ⬇️
unittests 93.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@varshith257
Copy link
Contributor Author

varshith257 commented May 18, 2024

@yurishkuro Can you PTAL at the Cassandra failing test? It's looks weird printing too many logs

@yurishkuro yurishkuro changed the title Bring code coverage back to 95% Restore code coverage threshold back to 95% May 18, 2024
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label May 18, 2024
@yurishkuro yurishkuro merged commit f6d60eb into jaegertracing:main May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:ci Change related to continuous integration / testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bring code coverage back to 95%

2 participants