Remove elasticsearch v5/v6 from tests

[FlamingSaint]

Which problem is this PR solving?

• Part of [Deprecation] Drop support for Elasticsearch v5 / v6 #5439

Description of the changes

• Removed instances of v5/v6 in the tests.

How was this change tested?

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.46%. Comparing base (afd39dd) to head (627da08).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5451   +/-   ##
=======================================
  Coverage   95.46%   95.46%           
=======================================
  Files         331      331           
  Lines       16113    16113           
=======================================
  Hits        15383    15383           
  Misses        556      556           
  Partials      174      174           

Flag	Coverage Δ
badger_v1	8.07% <ø> (ø)
cassandra-3.x-v1	16.48% <ø> (ø)
cassandra-3.x-v2	1.86% <ø> (ø)
cassandra-4.x-v1	16.48% <ø> (ø)
cassandra-4.x-v2	1.86% <ø> (ø)
elasticsearch-7.x	1.77% <ø> (-0.02%)	⬇️
elasticsearch-8.x	1.78% <ø> (ø)
grpc_v1	9.12% <ø> (ø)
grpc_v2	7.49% <ø> (ø)
kafka	9.81% <ø> (ø)
opensearch-1.x	1.77% <ø> (-0.02%)	⬇️
opensearch-2.x	1.77% <ø> (ø)
unittests	93.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yurishkuro]

thanks

[yurishkuro]

I initially thought you ran across flaky tests, but these are real errors:

=== RUN   TestIndexRollover_CreateIndicesWithILM/DefaultPolicyName/NoPrefix
    es_index_rollover_test.go:100: 
        	Error Trace:	/home/runner/work/jaeger/jaeger/plugin/storage/integration/es_index_rollover_test.go:100
        	            				/home/runner/work/jaeger/jaeger/plugin/storage/integration/es_index_rollover_test.go:76
        	Error:      	Received unexpected error:
        	            	elastic: Error 400 (Bad Request): Invalid index name [_ilm], must not start with '_', '-', or '+' [type=invalid_index_name_exception]

[FlamingSaint]

I initially thought you ran across flaky tests, but these are real errors:

=== RUN   TestIndexRollover_CreateIndicesWithILM/DefaultPolicyName/NoPrefix
    es_index_rollover_test.go:100: 
        	Error Trace:	/home/runner/work/jaeger/jaeger/plugin/storage/integration/es_index_rollover_test.go:100
        	            				/home/runner/work/jaeger/jaeger/plugin/storage/integration/es_index_rollover_test.go:76
        	Error:      	Received unexpected error:
        	            	elastic: Error 400 (Bad Request): Invalid index name [_ilm], must not start with '_', '-', or '+' [type=invalid_index_name_exception]

Okay. I will try fixing it.

[FlamingSaint]

@yurishkuro is the error in the CIT badger v2 due to a flaky test ? I am not sure why the CI test for Badger v2 is failing

[yurishkuro]

yes, most likely, thanks for reminding