Moving global write permissions down into the CI jobs #5370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Kowall <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5370 +/- ##
==========================================
+ Coverage 95.08% 95.21% +0.13%
==========================================
Files 343 343
Lines 16777 16781 +4
==========================================
+ Hits 15952 15978 +26
+ Misses 629 605 -24
- Partials 196 198 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jkowall
added
the
changelog:ci
yurishkuro
approved these changes
Apr 17, 2024
varshith257
pushed a commit
to varshith257/jaeger
that referenced
this pull request
May 3, 2024
…5370) This attempts to solve the following issue with our security rating around token permissions on the scorecard : https://securityscorecards.dev/viewer/?uri=github.com/jaegertracing/jaeger  ## Which problem is this PR solving? Part of jaegertracing#5363 ## Description of the changes Moving write permissions into the jobs ## How was this change tested? It will be tested after the PR is submitted as the jobs do not fully run on my fork. ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [NA] I have added unit tests for the new functionality - [NA] I have run lint and test steps successfully Signed-off-by: Jonah Kowall <[email protected]> Signed-off-by: Vamshi Maskuri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to solve the following issue with our security rating around token permissions on the scorecard : https://securityscorecards.dev/viewer/?uri=github.com/jaegertracing/jaeger
Which problem is this PR solving?
Part of #5363
Description of the changes
Moving write permissions into the jobs
How was this change tested?
It will be tested after the PR is submitted as the jobs do not fully run on my fork.
Checklist