Skip to content

Conversation

@prakrit55
Copy link
Contributor

Which problem is this PR solving?

Fixes: #5173

Checklist

@prakrit55 prakrit55 requested a review from a team as a code owner February 7, 2024 14:10
@prakrit55 prakrit55 requested a review from yurishkuro February 7, 2024 14:10
- name: Upload coverage to codecov
uses: codecov/codecov-action@894ff025c7b54547a9a2a1e9f228beae737ad3c2 # v3.1.3
- name: Retry action for codecov uploads
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name of the step is still Upload coverage to codecov

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@codecov
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (84385fe) 95.67% compared to head (7265fc3) 94.05%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5184      +/-   ##
==========================================
- Coverage   95.67%   94.05%   -1.63%     
==========================================
  Files         325      331       +6     
  Lines       18639    19156     +517     
==========================================
+ Hits        17833    18017     +184     
- Misses        647      957     +310     
- Partials      159      182      +23     
Flag Coverage Δ
cassandra-3.x 25.58% <ø> (ø)
cassandra-4.x 25.58% <ø> (ø)
elasticsearch-5.x 19.85% <ø> (-0.02%) ⬇️
elasticsearch-6.x 19.85% <ø> (-0.02%) ⬇️
elasticsearch-7.x 19.98% <ø> (ø)
elasticsearch-8.x 20.08% <ø> (ø)
grpc-badger 19.48% <ø> (-0.02%) ⬇️
kafka 14.09% <ø> (ø)
opensearch-1.x 20.00% <ø> (ø)
opensearch-2.x 20.00% <ø> (ø)
unittests 91.82% <ø> (-1.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Griffin <[email protected]>
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Feb 8, 2024
@yurishkuro yurishkuro closed this in 75067c5 May 3, 2024
pushkarm029 pushed a commit to pushkarm029/jaeger that referenced this pull request May 4, 2024
## Which problem is this PR solving?
- Objective is to cut down on the number of CI failures that are often
due to codecov uploads failing
- Resolves jaegertracing#5173
- Supersedes and closes jaegertracing#5184

## Description of the changes
- Add a new helper action which encapsulates defining a CODECOV token
and uploading with retries

## How was this change tested?
- CI

---------

Signed-off-by: Yuri Shkuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:ci Change related to continuous integration / testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add retries to codecov uploads

2 participants