Skip to content

fix: add keyboard accessibility to span name and child expander in Trace Timeline #3807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yurishkuro merged 4 commits into from
May 10, 2026
Merged

fix: add keyboard accessibility to span name and child expander in Trace Timeline #3807

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c240be3
fix: add keyboard accessibility to span name and child expander in Tr…
swetalin-10 May 4, 2026
f230d2b
fix: only add tabIndex and onKeyDown when onClick is provided, add ar…
swetalin-10 May 4, 2026
054a1be
Merge branch 'main' into fix/keyboard-accessibility-trace-timeline-3804
yurishkuro May 10, 2026
7ac570b
test: add keyboard accessibility tests for SpanBarRow and SpanTreeOffset
swetalin-10 May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanBarRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,15 @@ const SpanBarRow: React.FC<SpanBarRowProps> = ({
onChildrenToggled(span.spanID);
}, [onChildrenToggled, span.spanID]);

const _detailToggleKeyDown = useCallback(
(e: React.KeyboardEvent) => {
if (e.key === 'Enter' || e.key === ' ') {
e.preventDefault();
onDetailToggled(span.spanID);
}
},
[onDetailToggled, span.spanID]
);
Comment on lines +97 to +105
const {
duration,
hasChildren: isParent,
Expand Down Expand Up @@ -143,6 +152,7 @@ const SpanBarRow: React.FC<SpanBarRowProps> = ({
className={`span-name ${isDetailExpanded ? 'is-detail-expanded' : ''}`}
aria-checked={isDetailExpanded}
onClick={_detailToggle}
onKeyDown={_detailToggleKeyDown}
role="switch"
style={{ borderColor: color }}
tabIndex={0}
Expand Down
20 changes: 19 additions & 1 deletion packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanTreeOffset.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,25 @@ export const UnconnectedSpanTreeOffset: React.FC<TProps> = ({
};

const { hasChildren, spanID, childSpans } = span;
const wrapperProps = hasChildren ? { onClick, role: 'switch', 'aria-checked': childrenVisible } : null;
const _childrenToggleKeyDown = (e: React.KeyboardEvent) => {
if ((e.key === 'Enter' || e.key === ' ') && onClick) {
e.preventDefault();
onClick();
}
};
Comment thread
yurishkuro marked this conversation as resolved.

const wrapperProps = hasChildren
? {
onClick,
...(onClick && {
onKeyDown: _childrenToggleKeyDown,
tabIndex: 0,
}),
role: 'switch',
'aria-checked': childrenVisible,
'aria-label': 'Expand or collapse child spans',
}
: null;
Comment thread
yurishkuro marked this conversation as resolved.
Outdated

// Get parent color for horizontal line
const parentSpan = span.parentSpan;
Expand Down
Loading