Skip to content

fix: Dark mode is not working correctly on the Quality Metrics page#3583

Merged
yurishkuro merged 1 commit into
jaegertracing:mainfrom
gulshank0:issue/3566
Mar 9, 2026
Merged

fix: Dark mode is not working correctly on the Quality Metrics page#3583
yurishkuro merged 1 commit into
jaegertracing:mainfrom
gulshank0:issue/3566

Conversation

@gulshank0
Copy link
Copy Markdown
Contributor

Which problem is this PR solving?

Description of the changes

The Quality Metrics page CSS files used hardcoded color values like => (#fafafa, #ddd, rgba(0,0,0,) that don't adapt when the theme switches to dark mode. The project uses CSS custom properties (design tokens) defined in vars.css with [data-theme='dark'] overrides, but the Quality Metrics components weren't using them.

  • In dark mode :
Screenshot_09-Mar_00-39-20_31646
  • In Light mode :
Screenshot_09-Mar_00-40-17_30916

How was this change tested?

  • npm test
  • npm run build
  • npm run lint

Checklist

AI Usage in this PR (choose one)

See AI Usage Policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Copilot AI review requested due to automatic review settings March 8, 2026 19:14
@gulshank0 gulshank0 requested a review from a team as a code owner March 8, 2026 19:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Quality Metrics page styling to be theme-aware by replacing hardcoded light-theme colors/shadows with existing CSS custom properties (design tokens) so the page renders correctly in dark mode.

Changes:

  • Apply themed surface + text colors to the Quality Metrics page container.
  • Replace hardcoded borders and shadows in header/cards with --border-* and --shadow-sm tokens.
  • Align Quality Metrics component styles with the shared token system in vars.css.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/jaeger-ui/src/components/QualityMetrics/index.css Sets themed background and base text color for the Quality Metrics page.
packages/jaeger-ui/src/components/QualityMetrics/Header.css Switches header background/border/shadow to design tokens for dark-mode compatibility.
packages/jaeger-ui/src/components/QualityMetrics/MetricCard.css Replaces card borders and shadows with tokenized values.
packages/jaeger-ui/src/components/QualityMetrics/ScoreCard.css Tokenizes title header border and shadow.
packages/jaeger-ui/src/components/QualityMetrics/CountCard.css Tokenizes title header border and shadow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.16%. Comparing base (72014ef) to head (b0a9d8f).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3583   +/-   ##
=======================================
  Coverage   89.16%   89.16%           
=======================================
  Files         303      303           
  Lines        9712     9712           
  Branches     2556     2588   +32     
=======================================
  Hits         8660     8660           
+ Misses       1049     1048    -1     
- Partials        3        4    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Mar 9, 2026
@yurishkuro yurishkuro merged commit a8368e2 into jaegertracing:main Mar 9, 2026
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Dark mode is not working correctly on the Quality Metrics page

3 participants