fix: Dark mode is not working correctly on the Quality Metrics page#3583
Merged
Conversation
Signed-off-by: gulshank0 <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Quality Metrics page styling to be theme-aware by replacing hardcoded light-theme colors/shadows with existing CSS custom properties (design tokens) so the page renders correctly in dark mode.
Changes:
- Apply themed surface + text colors to the Quality Metrics page container.
- Replace hardcoded borders and shadows in header/cards with
--border-*and--shadow-smtokens. - Align Quality Metrics component styles with the shared token system in
vars.css.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/jaeger-ui/src/components/QualityMetrics/index.css | Sets themed background and base text color for the Quality Metrics page. |
| packages/jaeger-ui/src/components/QualityMetrics/Header.css | Switches header background/border/shadow to design tokens for dark-mode compatibility. |
| packages/jaeger-ui/src/components/QualityMetrics/MetricCard.css | Replaces card borders and shadows with tokenized values. |
| packages/jaeger-ui/src/components/QualityMetrics/ScoreCard.css | Tokenizes title header border and shadow. |
| packages/jaeger-ui/src/components/QualityMetrics/CountCard.css | Tokenizes title header border and shadow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3583 +/- ##
=======================================
Coverage 89.16% 89.16%
=======================================
Files 303 303
Lines 9712 9712
Branches 2556 2588 +32
=======================================
Hits 8660 8660
+ Misses 1049 1048 -1
- Partials 3 4 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
The Quality Metrics page CSS files used hardcoded color values like => (#fafafa, #ddd, rgba(0,0,0,) that don't adapt when the theme switches to dark mode. The project uses CSS custom properties (design tokens) defined in
vars.csswith[data-theme='dark']overrides, but the Quality Metrics components weren't using them.How was this change tested?
Checklist
make lint testAI Usage in this PR (choose one)
See AI Usage Policy.