Allow viewing span details in a side panel instead of inline view#3578
Merged
Conversation
Signed-off-by: Yuri Shkuro <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Jaeger UI’s default configuration to enable the trace timeline “side panel span details” feature flag by default, while keeping inline as the initial detail view mode.
Changes:
- Flip
traceTimeline.enableSidePaneldefault fromfalsetotrue - Keep
traceTimeline.defaultDetailPanelModedefault as'inline'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3578 +/- ##
=======================================
Coverage 89.15% 89.15%
=======================================
Files 303 303
Lines 9698 9698
Branches 2584 2585 +1
=======================================
Hits 8646 8646
+ Misses 1049 1048 -1
- Partials 3 4 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Yuri Shkuro <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes
traceTimeline.defaultDetailPanelMode="sidepanel"config option.Previous phases: Phase 1 #3558, Phase 2 #3562, Phase 3 #3569, Phase 4 #3576, Phase 5 #3577.