[Feature]: Add Trace Logs view to aggregate all span events #3563
Conversation
Add a new 'Trace Logs' tab to the trace detail page that collects all log events from every span in a trace and displays them in a chronologically sorted table. The view includes columns for timestamp, service name, span name, event name, attributes, and a linked span ID. Supports both OTel and legacy terminology. Resolves jaegertracing#1377 Signed-off-by: SoumyaRaikwar <[email protected]>
Update AltViewOptions and TracePageHeader.track tests to cover the new TraceLogs view type menu item and tracking. Signed-off-by: SoumyaRaikwar <[email protected]>
|
please add screenshots |
@yurishkuro Here are the screenshots: |
|
a few comments:
|
@yurishkuro, thanks for catching dark mode i completely forgot that.
|
- Use AccordionAttributes expandable widget for attributes - Fix column widths for better layout efficiency - Consistent terminology: Tags/Attributes based on config flag - Verify dark mode compatibility Signed-off-by: SoumyaRaikwar <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Signed-off-by: Soumya Raikwar <[email protected]>
…x.tsx Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Soumya Raikwar <[email protected]>
Signed-off-by: Soumya Raikwar <[email protected]>
|
please improve test coverage, see #3563 (comment) |
Signed-off-by: SoumyaRaikwar <[email protected]>
Done, improved in the latest commit. |
|
code coverage is still down |
Signed-off-by: SoumyaRaikwar <[email protected]>
Head branch was pushed to by a user without write access
sorry for it, i updated it. |





Which problem is this PR solving?
Description of the changes
ETraceViewTypeenum, tracking action, and menu entry in the view selector dropdown.How was this change tested?
TracePageHeader.trackto cover the new view type.Checklist
make lint testAI Usage in this PR (choose one)
See AI Usage Policy.