refactor(plexus): migrate Digraph to functional component by hharshhsaini · Pull Request #3534 · jaegertracing/jaeger-ui

hharshhsaini · 2026-02-09T19:51:03Z

Which problem is this PR solving?

Resolves [UI Refactor] [plexus] Migrate Digraph to Functional Component #3386
Part of [Feature]: Refactor class components to functional components #2610 - Jaeger UI modernization (refactor class components to functional components)

Description of the changes

Migrated Digraph component from class-based to functional component
Converted this.state to useState for state management
Replaced componentDidMount lifecycle method with useEffect hook
Converted memoizeOne to useMemo for className factory memoization
Converted instance variables (baseId, rootRef, zoomManager) to useRef
Maintained PureComponent behavior with React.memo wrapper
Preserved all static properties (propsFactories, scaleProperty)
All existing tests pass without modification

Component Migration Details

Converted class component to functional component
Replaced this.state with useState (8 state variables)
Converted componentDidMount to useEffect
Replaced memoizeOne with useMemo
Converted instance variables to useRef
Wrapped component with React.memo for performance
Preserved static properties on memoized component

State Management

edges - array of graph edges
layoutEdges - processed layout edges
layoutGraph - graph layout data
layoutPhase - current layout phase
layoutVertices - processed layout vertices
sizeVertices - vertex size data
vertices - array of graph vertices
zoomTransform - zoom transformation state

Hooks Migration

useState for component state
useEffect for lifecycle (componentDidMount)
useRef for instance variables (baseId, rootRef, zoomManager)
useMemo for memoized values (className factory, renderUtils)
useCallback for callbacks (getGlobalId, getZoomTransform, onLayoutDone, setSizeVertices, renderLayers)

How was this change tested?

Ran npm run prettier - formatting correct
Ran npm run tsc-lint - TypeScript type checking passing (no new errors)
Ran npm run lint - passing (249 pre-existing warnings, 0 errors)
Ran npm test -- packages/plexus - all 18 tests passing
Ran npm run build --workspace=@jaegertracing/plexus - build successful

Test proof -

Code Quality

Minimal changes - only 4 files modified
348 insertions, 195 deletions (net +153 lines)
All hooks have correct dependency arrays
No stale closures or infinite loops
Performance maintained with React.memo

Checklist

I have read https://github.com/jaegertracing/jaeger/blob/main/CONTRIBUTING_GUIDELINES.md
I have signed all commits
I have added unit tests for the new functionality (N/A - migration maintains existing functionality)
I have run lint and test steps successfully:
- npm run prettier
- npm run lint
- npm run tsc-lint
- npm test
- npm run build

AI Usage in this PR

See AI Usage Policy.

None: No AI tools were used in creating this PR
Light: AI provided minor assistance (formatting, simple suggestions)
Moderate: AI helped with code generation or debugging specific parts
Heavy: AI generated most or all of the code changes

github-actions · 2026-02-19T14:22:55Z

Hi @hharshhsaini, thanks for your contribution! To ensure quality reviews, we limit how many concurrent open PRs new contributors can open.

This PR is currently on hold (Status: 10/1 open). We will automatically move this into the review queue once your existing PRs are merged or closed.

Please see our Contributing Guidelines for details on our tiered quota policy.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

jkowall · 2026-03-06T02:06:41Z

@hharshhsaini please address copilot comments.

codecov · 2026-03-06T11:00:29Z

Codecov Report

❌ Patch coverage is 91.66667% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.78%. Comparing base (42b5388) to head (c508511).
⚠️ Report is 30 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/plexus/src/Digraph/index.tsx	90.76%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3534      +/-   ##
==========================================
+ Coverage   88.68%   90.78%   +2.10%     
==========================================
  Files         300      304       +4     
  Lines        9560     9731     +171     
  Branches     2445     2595     +150     
==========================================
+ Hits         8478     8834     +356     
+ Misses       1078      894     -184     
+ Partials        4        3       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Convert class component to functional component with hooks - Replace this.state with useState for state management - Convert componentDidMount to useEffect hook - Replace memoizeOne with useMemo for className factory - Convert instance variables to useRef (baseId, rootRef, zoomManager) - Maintain PureComponent behavior with React.memo - Preserve all static properties (propsFactories, scaleProperty) - All existing tests pass without modification Resolves jaegertracing#3386 Signed-off-by: hharshhsaini <sainiharsh3311@gmail.com>

hharshhsaini · 2026-03-12T16:51:24Z

@jkowall Fixed, Added a public dispose() method to ZoomManager that removes all d3-zoom event listeners via selection.on('.zoom', null) and clears internal references. The useEffect in Digraph now returns a cleanup function that calls dispose() whenever zoomManager changes (i.e. zoom prop is toggled off) or when the component unmounts, so prior listeners can no longer fire on the DOM element.

Copilot

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…anager - Use never-resolving promise in mockLayoutManager to avoid React 'not wrapped in act()' warnings from async state updates in tests - Assert .plexus-MiniMap element instead of generic svg selector to make MiniMap test specific and avoid false positives - Reset contentSize and currentTransform in ZoomManager.dispose() so instance is fully returned to initial state after teardown - Fix misleading renderLayers comment: renderUtils is stable (memoized); the real reason no useCallback is needed is that state changes on every layout phase update and zoom event Signed-off-by: hharshhsaini <sainiharsh3311@gmail.com>

hharshhsaini · 2026-03-12T17:08:13Z

@jkowall addressed and resolved all the github sugestions , with coments and fixes.

jkowall · 2026-03-12T19:08:46Z

@hharshhsaini why are you changing the lockfile?

Signed-off-by: hharshhsaini <sainiharsh3311@gmail.com>

hharshhsaini · 2026-03-12T19:20:45Z

@hharshhsaini why are you changing the lockfile?

@jkowall Sorry about that, it was an unintentional artifact from running npm install locally. Restored package-lock.json to match upstream main.

Copilot

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: hharshhsaini <sainiharsh3311@gmail.com>

jkowall · 2026-03-12T19:51:56Z

@hharshhsaini been there before, will approve.

jkowall

Looks good, thanks for the contribution.

…egertracing#3534)" This reverts commit 5114ee3. Signed-off-by: Yuri Shkuro <github@ysh.us>

yurishkuro · 2026-03-12T23:42:20Z

reverting #3600

…3600) This reverts commit 5114ee3. Code Review: PR #3534 — `refactor(plexus): migrate Digraph to functional component` **Status: MERGED** | 1,053 additions, 531 deletions across 5 files --- ## Overview This PR migrates `packages/plexus/src/Digraph/index.tsx` from a class component to a functional component, as part of the broader React modernization effort (#2610). It also adds a `dispose()` method to `ZoomManager` and introduces a new test file. The general direction is correct and the migration is largely sound. --- ## Positive Aspects - **`dispose()` on `ZoomManager`** is a valuable addition — it properly removes d3-zoom event listeners to prevent leaks when zoom is toggled or the component unmounts. - **`builtinStyle` based on `zoomEnabled` prop** instead of checking `zoomManagerRef.current` eliminates the initial paint/layout shift bug present in the original design. - **Single atomic `setState`** in `setSizeVertices` is an improvement over the original class component which had two `setState` calls (first setting `sizeVertices` alone, then redundantly re-setting it alongside `layoutPhase`). - **Lazy ref initialization** for `baseId` correctly gates the `idCounter++` side-effect behind an `if (!baseIdRef.current)` guard. - **`zoomTransformRef` pattern** for `getZoomTransform` is the right approach — stable callback via `[]` deps that always returns the latest transform. --- ## Issues ### 1. `setSizeVertices` stability regression (potential performance issue) ```tsx // packages/plexus/src/Digraph/index.tsx const setSizeVertices = React.useCallback( (senderKey: string, sizeVertices: TSizeVertex<T>[]) => { ... }, [edges, layoutManager, measurableNodesKey, onLayoutDone] // recreated on new edges prop ); ``` In the original class component, `setSizeVertices` was a stable method reference — it never changed identity. Now it is recreated whenever `edges` or `layoutManager` changes. This means `MeasurableNodesLayer` (which receives `setSizeVertices` as a prop) will re-render on every parent re-render that produces a new `edges` array reference, even if the edge data hasn't changed. Consider using a ref-based approach like `onLayoutDone` does — capture `edges` and `layoutManager` in a ref updated each render, and give `setSizeVertices` `[]` deps. ### 2. `onLayoutDone` empty dep array is correct but undocumented ```tsx const onLayoutDone = React.useCallback((result: ...) => { ... if (zoomManagerRef.current) { zoomManagerRef.current.setContentSize(layoutGraph); } }, []); // empty deps ``` This is correct because `setState` is stable and `zoomManagerRef` is a ref. However, there is no comment explaining why empty deps are appropriate here, which can look like a mistake to future readers. ### 3. Generic type erasure with `React.memo` ```tsx const DigraphMemo = React.memo(Digraph) as unknown as TDigraphComponent; ``` The `as unknown as TDigraphComponent` cast drops the generic `<T, U>` parameters. Downstream callers using `<Digraph<MyNode, MyEdge> .../>` lose type safety. The comment in the PR acknowledges this is a known React limitation — that is fine for now, but it should be tracked as a follow-up since it is a type regression from the original. ### 4. Redundant `zoomManagerRef` ```tsx const zoomManager = React.useMemo(() => { ... }, [zoomEnabled]); const zoomManagerRef = React.useRef<ZoomManager | null>(zoomManager); zoomManagerRef.current = zoomManager; ``` `zoomManagerRef` is only used in `onLayoutDone` (to avoid stale closure with `[]` deps). The pattern works, but mutating a ref during render (`zoomManagerRef.current = zoomManager`) is technically a side effect in the render phase. Since `zoomManager` comes from `useMemo`, this is benign in practice, but a comment would help clarify the intent. ### 5. Unrelated dependency updates in `package-lock.json` The PR mixes the functional component refactor with `package-lock.json` updates (`@typescript-eslint` 8.50→8.56, various `@rc-component/*` bumps, rollup 4.53→4.59, etc.). These lockfile-only changes should be in a separate PR for easier review and bisectability. ### 6. New test file: copyright header inconsistency ```tsx // Copyright (c) 2026 Uber Technologies, Inc. ``` Other plexus source files use `Uber Technologies, Inc.` (consistent with the original 2019 header), but `CLAUDE.md` specifies `The Jaeger Authors.` as the expected copyright holder for new files. This should be reconciled. ### 7. Test: `getLayout` assertion has edge-case fragility ```tsx // index.test.tsx expect(getLayout).toHaveBeenCalledWith(edges, expect.any(Array)); ``` `getLayout` is called inside `setSizeVertices`, which is triggered by `MeasurableNodesLayer` measuring nodes. The test relies on `measureNode: () => ({ height: 10, width: 10 })` being called synchronously during render. This works today but is implementation-dependent. A comment explaining why this fires synchronously (RTL flushes sync measurement in the DOM render) would help future maintainers. --- ## Summary The migration is functionally correct and the tests pass. The main concerns are: | Priority | Issue | | --------- | ------------------------------------------------------------------------ | | Medium | `setSizeVertices` recreated on `edges` change — potential render churn | | Low | Generic type erasure via `React.memo` cast (needs follow-up tracking) | | Low | `package-lock.json` changes mixed into refactor PR | | Cosmetic | Copyright header in new test file | | Cosmetic | Missing comments explaining empty `[]` dep arrays | Signed-off-by: Yuri Shkuro <github@ysh.us>

hharshhsaini · 2026-03-13T05:00:03Z

reverting #3600

@yurishkuro sir , may I know the reasons for reverting the PRs , while completing all the sugestions from both the maintainers @jkowall @yurishkuro . Its been confusing for performing the different different changes again and again.

yurishkuro · 2026-03-13T13:52:29Z

There is a summary in the reverting PR. This should not have been merged with existing issues.

…ing#3534) ## Which problem is this PR solving? - Resolves jaegertracing#3386 - Part of jaegertracing#2610 - Jaeger UI modernization (refactor class components to functional components) ## Description of the changes - Migrated Digraph component from class-based to functional component - Converted this.state to useState for state management - Replaced componentDidMount lifecycle method with useEffect hook - Converted memoizeOne to useMemo for className factory memoization - Converted instance variables (baseId, rootRef, zoomManager) to useRef - Maintained PureComponent behavior with React.memo wrapper - Preserved all static properties (propsFactories, scaleProperty) - All existing tests pass without modification ## Component Migration Details - [x] Converted class component to functional component - [x] Replaced this.state with useState (8 state variables) - [x] Converted componentDidMount to useEffect - [x] Replaced memoizeOne with useMemo - [x] Converted instance variables to useRef - [x] Wrapped component with React.memo for performance - [x] Preserved static properties on memoized component ## State Management - [x] edges - array of graph edges - [x] layoutEdges - processed layout edges - [x] layoutGraph - graph layout data - [x] layoutPhase - current layout phase - [x] layoutVertices - processed layout vertices - [x] sizeVertices - vertex size data - [x] vertices - array of graph vertices - [x] zoomTransform - zoom transformation state ## Hooks Migration - [x] useState for component state - [x] useEffect for lifecycle (componentDidMount) - [x] useRef for instance variables (baseId, rootRef, zoomManager) - [x] useMemo for memoized values (className factory, renderUtils) - [x] useCallback for callbacks (getGlobalId, getZoomTransform, onLayoutDone, setSizeVertices, renderLayers) ## How was this change tested? - [x] Ran npm run prettier - formatting correct - [x] Ran npm run tsc-lint - TypeScript type checking passing (no new errors) - [x] Ran npm run lint - passing (249 pre-existing warnings, 0 errors) - [x] Ran npm test -- packages/plexus - all 18 tests passing - [x] Ran npm run build --workspace=@jaegertracing/plexus - build successful ## Test proof - <img width="428" height="147" alt="3386 proof" src="https://github.com/user-attachments/assets/d55cd1e2-5177-40da-89f2-da3a3303be0a" /> ## Code Quality - [x] Minimal changes - only 4 files modified - [x] 348 insertions, 195 deletions (net +153 lines) - [x] All hooks have correct dependency arrays - [x] No stale closures or infinite loops - [x] Performance maintained with React.memo ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/main/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality (N/A - migration maintains existing functionality) - [x] I have run lint and test steps successfully: - npm run prettier - npm run lint - npm run tsc-lint - npm test - npm run build ## AI Usage in this PR See AI Usage Policy. - [ ] None: No AI tools were used in creating this PR - [x] Light: AI provided minor assistance (formatting, simple suggestions) - [ ] Moderate: AI helped with code generation or debugging specific parts - [ ] Heavy: AI generated most or all of the code changes --------- Signed-off-by: hharshhsaini <sainiharsh3311@gmail.com>

…aegertracing#3600) This reverts commit 5114ee3. Code Review: PR jaegertracing#3534 — `refactor(plexus): migrate Digraph to functional component` **Status: MERGED** | 1,053 additions, 531 deletions across 5 files --- ## Overview This PR migrates `packages/plexus/src/Digraph/index.tsx` from a class component to a functional component, as part of the broader React modernization effort (jaegertracing#2610). It also adds a `dispose()` method to `ZoomManager` and introduces a new test file. The general direction is correct and the migration is largely sound. --- ## Positive Aspects - **`dispose()` on `ZoomManager`** is a valuable addition — it properly removes d3-zoom event listeners to prevent leaks when zoom is toggled or the component unmounts. - **`builtinStyle` based on `zoomEnabled` prop** instead of checking `zoomManagerRef.current` eliminates the initial paint/layout shift bug present in the original design. - **Single atomic `setState`** in `setSizeVertices` is an improvement over the original class component which had two `setState` calls (first setting `sizeVertices` alone, then redundantly re-setting it alongside `layoutPhase`). - **Lazy ref initialization** for `baseId` correctly gates the `idCounter++` side-effect behind an `if (!baseIdRef.current)` guard. - **`zoomTransformRef` pattern** for `getZoomTransform` is the right approach — stable callback via `[]` deps that always returns the latest transform. --- ## Issues ### 1. `setSizeVertices` stability regression (potential performance issue) ```tsx // packages/plexus/src/Digraph/index.tsx const setSizeVertices = React.useCallback( (senderKey: string, sizeVertices: TSizeVertex<T>[]) => { ... }, [edges, layoutManager, measurableNodesKey, onLayoutDone] // recreated on new edges prop ); ``` In the original class component, `setSizeVertices` was a stable method reference — it never changed identity. Now it is recreated whenever `edges` or `layoutManager` changes. This means `MeasurableNodesLayer` (which receives `setSizeVertices` as a prop) will re-render on every parent re-render that produces a new `edges` array reference, even if the edge data hasn't changed. Consider using a ref-based approach like `onLayoutDone` does — capture `edges` and `layoutManager` in a ref updated each render, and give `setSizeVertices` `[]` deps. ### 2. `onLayoutDone` empty dep array is correct but undocumented ```tsx const onLayoutDone = React.useCallback((result: ...) => { ... if (zoomManagerRef.current) { zoomManagerRef.current.setContentSize(layoutGraph); } }, []); // empty deps ``` This is correct because `setState` is stable and `zoomManagerRef` is a ref. However, there is no comment explaining why empty deps are appropriate here, which can look like a mistake to future readers. ### 3. Generic type erasure with `React.memo` ```tsx const DigraphMemo = React.memo(Digraph) as unknown as TDigraphComponent; ``` The `as unknown as TDigraphComponent` cast drops the generic `<T, U>` parameters. Downstream callers using `<Digraph<MyNode, MyEdge> .../>` lose type safety. The comment in the PR acknowledges this is a known React limitation — that is fine for now, but it should be tracked as a follow-up since it is a type regression from the original. ### 4. Redundant `zoomManagerRef` ```tsx const zoomManager = React.useMemo(() => { ... }, [zoomEnabled]); const zoomManagerRef = React.useRef<ZoomManager | null>(zoomManager); zoomManagerRef.current = zoomManager; ``` `zoomManagerRef` is only used in `onLayoutDone` (to avoid stale closure with `[]` deps). The pattern works, but mutating a ref during render (`zoomManagerRef.current = zoomManager`) is technically a side effect in the render phase. Since `zoomManager` comes from `useMemo`, this is benign in practice, but a comment would help clarify the intent. ### 5. Unrelated dependency updates in `package-lock.json` The PR mixes the functional component refactor with `package-lock.json` updates (`@typescript-eslint` 8.50→8.56, various `@rc-component/*` bumps, rollup 4.53→4.59, etc.). These lockfile-only changes should be in a separate PR for easier review and bisectability. ### 6. New test file: copyright header inconsistency ```tsx // Copyright (c) 2026 Uber Technologies, Inc. ``` Other plexus source files use `Uber Technologies, Inc.` (consistent with the original 2019 header), but `CLAUDE.md` specifies `The Jaeger Authors.` as the expected copyright holder for new files. This should be reconciled. ### 7. Test: `getLayout` assertion has edge-case fragility ```tsx // index.test.tsx expect(getLayout).toHaveBeenCalledWith(edges, expect.any(Array)); ``` `getLayout` is called inside `setSizeVertices`, which is triggered by `MeasurableNodesLayer` measuring nodes. The test relies on `measureNode: () => ({ height: 10, width: 10 })` being called synchronously during render. This works today but is implementation-dependent. A comment explaining why this fires synchronously (RTL flushes sync measurement in the DOM render) would help future maintainers. --- ## Summary The migration is functionally correct and the tests pass. The main concerns are: | Priority | Issue | | --------- | ------------------------------------------------------------------------ | | Medium | `setSizeVertices` recreated on `edges` change — potential render churn | | Low | Generic type erasure via `React.memo` cast (needs follow-up tracking) | | Low | `package-lock.json` changes mixed into refactor PR | | Cosmetic | Copyright header in new test file | | Cosmetic | Missing comments explaining empty `[]` dep arrays | Signed-off-by: Yuri Shkuro <github@ysh.us>

hharshhsaini requested a review from a team as a code owner February 9, 2026 19:51

github-actions Bot added the pr-quota-reached PR is on hold due to quota limits for new contributors label Feb 19, 2026

jkowall requested a review from Copilot March 5, 2026 19:19

Copilot AI reviewed Mar 5, 2026

jkowall requested a review from Copilot March 6, 2026 02:01

Copilot started reviewing on behalf of jkowall March 6, 2026 02:01 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

Comment thread packages/plexus/src/Digraph/index.tsx Outdated

Comment thread packages/plexus/src/Digraph/index.tsx Outdated

Comment thread packages/plexus/src/Digraph/index.tsx Outdated

github-actions Bot added the waiting-for-author PR is waiting for author to respond to maintainer's comments label Mar 6, 2026

hharshhsaini force-pushed the refactor/plexus-digraph-functional-component branch from 1fa6d95 to 7329a91 Compare March 6, 2026 10:57

github-actions Bot removed the waiting-for-author PR is waiting for author to respond to maintainer's comments label Mar 6, 2026

Copilot AI review requested due to automatic review settings March 6, 2026 11:06

Copilot started reviewing on behalf of hharshhsaini March 6, 2026 11:06 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

Comment thread packages/plexus/src/Digraph/index.tsx Outdated

Comment thread packages/plexus/src/Digraph/index.tsx Outdated

Comment thread packages/plexus/src/Digraph/index.tsx Outdated

hharshhsaini force-pushed the refactor/plexus-digraph-functional-component branch 4 times, most recently from 711fdc3 to c8d25fc Compare March 6, 2026 11:50

Copilot AI review requested due to automatic review settings March 6, 2026 11:50

Copilot started reviewing on behalf of hharshhsaini March 6, 2026 11:50 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

Comment thread packages/plexus/package.json

Comment thread packages/plexus/src/Digraph/index.tsx

Comment thread packages/plexus/src/Digraph/index.tsx Outdated

Comment thread packages/plexus/src/Digraph/index.test.tsx Outdated

hharshhsaini force-pushed the refactor/plexus-digraph-functional-component branch from c8d25fc to cd464ee Compare March 6, 2026 12:35

Copilot AI review requested due to automatic review settings March 6, 2026 12:40

hharshhsaini force-pushed the refactor/plexus-digraph-functional-component branch from cd464ee to 9c03659 Compare March 6, 2026 12:40

Copilot started reviewing on behalf of hharshhsaini March 6, 2026 12:42 View session

graphite-app Bot reviewed Mar 6, 2026

View reviewed changes

Comment thread packages/plexus/src/Digraph/index.tsx Outdated

Copilot AI reviewed Mar 6, 2026

View reviewed changes

Comment thread packages/plexus/src/Digraph/index.tsx Outdated

Comment thread packages/plexus/src/Digraph/index.tsx

Comment thread packages/plexus/src/Digraph/index.tsx

Copilot started reviewing on behalf of hharshhsaini March 12, 2026 16:48 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

github-actions Bot added the waiting-for-author PR is waiting for author to respond to maintainer's comments label Mar 12, 2026

chore: restore package-lock.json to match upstream main

181be57

Signed-off-by: hharshhsaini <sainiharsh3311@gmail.com>

Copilot AI review requested due to automatic review settings March 12, 2026 19:19

github-actions Bot removed the waiting-for-author PR is waiting for author to respond to maintainer's comments label Mar 12, 2026

Copilot started reviewing on behalf of hharshhsaini March 12, 2026 19:19 View session

Copilot AI reviewed Mar 12, 2026

View reviewed changes

chore: sync package-lock.json with upstream jaegertracing/main

c508511

Signed-off-by: hharshhsaini <sainiharsh3311@gmail.com>

github-actions Bot added the waiting-for-author PR is waiting for author to respond to maintainer's comments label Mar 12, 2026

jkowall approved these changes Mar 12, 2026

View reviewed changes

jkowall added this pull request to the merge queue Mar 12, 2026

Merged via the queue into jaegertracing:main with commit 5114ee3 Mar 12, 2026
15 checks passed

yurishkuro added a commit to yurishkuro/jaeger-ui that referenced this pull request Mar 12, 2026

Revert "refactor(plexus): migrate Digraph to functional component (ja…

63d2ed4

…egertracing#3534)" This reverts commit 5114ee3. Signed-off-by: Yuri Shkuro <github@ysh.us>

yurishkuro mentioned this pull request Mar 12, 2026

Revert "refactor(plexus): migrate Digraph to functional component" #3600

Merged

github-actions Bot removed the waiting-for-author PR is waiting for author to respond to maintainer's comments label Mar 13, 2026

github-actions Bot added the waiting-for-author PR is waiting for author to respond to maintainer's comments label Mar 13, 2026

Uh oh!

Conversation

hharshhsaini commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Which problem is this PR solving?

Description of the changes

Component Migration Details

State Management

Hooks Migration

How was this change tested?

Test proof -

Code Quality

Checklist

AI Usage in this PR

Uh oh!

github-actions Bot commented Feb 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkowall commented Mar 6, 2026

Uh oh!

codecov Bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hharshhsaini commented Mar 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hharshhsaini commented Mar 12, 2026

Uh oh!

jkowall commented Mar 12, 2026

Uh oh!

hharshhsaini commented Mar 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

jkowall commented Mar 12, 2026

Uh oh!

jkowall left a comment

hharshhsaini commented Feb 9, 2026 •

edited

Loading

codecov Bot commented Mar 6, 2026 •

edited

Loading