Skip to content

Enable react-hooks/exhaustive-deps linter rule #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yurishkuro merged 8 commits into from
Feb 3, 2026
Merged

Enable react-hooks/exhaustive-deps linter rule #3471

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7f247d8
Enable react-hooks/exhaustive-deps linter rule
taanvi2205 Jan 27, 2026
01cab1b
Fix DeepDependencies to use history.push instead of navigate
taanvi2205 Jan 28, 2026
a4e49e1
Merge branch 'main' into enable-react-hooks-exhaustive-deps
yurishkuro Jan 30, 2026
a9c0df1
Remove unrelated DeepDependencies changes
taanvi2205 Jan 31, 2026
37f6130
Remove yarn.lock
taanvi2205 Feb 2, 2026
5d39a76
Fix duplicate fetchMetrics calls in ServicesView
taanvi2205 Feb 2, 2026
0e7bb50
Fix VirtualizedTraceView props
taanvi2205 Feb 2, 2026
406d7a1
Add comment explaining eslint-disable for mount-only effect
taanvi2205 Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import js from '@eslint/js';
import typescriptPlugin from '@typescript-eslint/eslint-plugin';
import typescriptParser from '@typescript-eslint/parser';
import reactPlugin from 'eslint-plugin-react';
import reactHooksPlugin from 'eslint-plugin-react-hooks';
import jsxA11y from 'eslint-plugin-jsx-a11y';
import importPlugin from 'eslint-plugin-import';
import prettierPlugin from 'eslint-plugin-prettier';
Expand Down Expand Up @@ -112,6 +113,9 @@ const baseRules = {
},
],

'react-hooks/rules-of-hooks': 'error',
'react-hooks/exhaustive-deps': 'error',

'jsx-a11y/anchor-is-valid': 'off',
'jsx-a11y/click-events-have-key-events': 'off',
'jsx-a11y/href-no-hash': 'off',
Expand Down Expand Up @@ -198,6 +202,7 @@ export default [
plugins: {
'@typescript-eslint': typescriptPlugin,
react: reactPlugin,
'react-hooks': reactHooksPlugin,
'jsx-a11y': jsxA11y,
import: importPlugin,
prettier: prettierPlugin,
Expand Down Expand Up @@ -225,6 +230,7 @@ export default [
},
plugins: {
react: reactPlugin,
'react-hooks': reactHooksPlugin,
'jsx-a11y': jsxA11y,
import: importPlugin,
prettier: prettierPlugin,
Expand Down
112 changes: 94 additions & 18 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
"@babel/cli": "7.28.0",
"@babel/core": "7.28.5",
"@testing-library/dom": "^10.4.1",
"ajv": "^6.12.6",
"@typescript-eslint/eslint-plugin": "8.50.0",
"@typescript-eslint/parser": "8.50.0",
"ajv": "^6.12.6",
"cross-env": "10.1.0",
"depcheck": "1.4.7",
"eslint": "9.39.1",
Expand All @@ -27,6 +27,7 @@
"eslint-plugin-jsx-a11y": "6.10.2",
"eslint-plugin-prettier": "5.5.4",
"eslint-plugin-react": "7.37.5",
"eslint-plugin-react-hooks": "^7.0.1",
"eslint-plugin-testing-library": "7.15.1",
"husky": "9.1.0",
"jsdom": "27.4.0",
Expand Down
Loading