Skip to content

Better tree hierarchy for trace view#3302

Merged
yurishkuro merged 6 commits into
jaegertracing:mainfrom
yurishkuro:trace-tree
Jan 4, 2026
Merged

Better tree hierarchy for trace view#3302
yurishkuro merged 6 commits into
jaegertracing:mainfrom
yurishkuro:trace-tree

Conversation

@yurishkuro
Copy link
Copy Markdown
Member

@yurishkuro yurishkuro commented Jan 4, 2026

Which problem is this PR solving?

Description of the changes

  • uses boxes with direct children counts
  • draws service-colored lines directly
  • make inferred vs. own error icons display differently (hollow vs. solid exclamation icon)

How was this change tested?

image

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro added the changelog:new-feature Change that should be called out as new feature in CHANGELOG label Jan 4, 2026
@yurishkuro yurishkuro requested a review from a team as a code owner January 4, 2026 20:41
@yurishkuro yurishkuro requested review from mahadzaryab1 and removed request for a team January 4, 2026 20:41
yurishkuro and others added 4 commits January 4, 2026 15:53
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 4, 2026

Codecov Report

❌ Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.10%. Comparing base (1f98f5f) to head (6d3a15f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nents/TracePage/TraceTimelineViewer/SpanBarRow.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3302      +/-   ##
==========================================
- Coverage   97.10%   97.10%   -0.01%     
==========================================
  Files         266      266              
  Lines        8359     8389      +30     
  Branches     2214     2231      +17     
==========================================
+ Hits         8117     8146      +29     
- Misses        239      240       +1     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro merged commit 19e3bf6 into jaegertracing:main Jan 4, 2026
11 checks passed
@yurishkuro yurishkuro deleted the trace-tree branch January 4, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:new-feature Change that should be called out as new feature in CHANGELOG

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trace - Indicate the number of descendants for a given row

1 participant