Skip to content

Fix highlighting of the current tab in the main nav bar#3183

Merged
yurishkuro merged 1 commit into
jaegertracing:mainfrom
SimonADW:navhighlight
Nov 28, 2025
Merged

Fix highlighting of the current tab in the main nav bar#3183
yurishkuro merged 1 commit into
jaegertracing:mainfrom
SimonADW:navhighlight

Conversation

@SimonADW
Copy link
Copy Markdown
Contributor

@SimonADW SimonADW commented Nov 28, 2025

Which problem is this PR solving?

Description of the changes

  • Destructure pathname from props to get the updated pathname passed down from withRouteProps rather than Redux.
  • Update Props type to include IWithRouteProps as well as ReduxState.

How was this change tested?

  • With npm test -- --coverage
    Test Suites: 205 passed, 205 total
    Tests: 2263 passed, 2263 total
    Snapshots: 3 passed, 3 total
    Time: 48.913 s
    Ran all test suites.

Checklist

Destructure pathname from props to get the updated pathname
passed down from withRouteProps rather than Redux.

Update Props type to include IWithRouteProps as well as ReduxState

Signed-off-by: SimonADW <[email protected]>
@SimonADW SimonADW requested a review from a team as a code owner November 28, 2025 20:54
@SimonADW SimonADW requested review from joe-elliott and removed request for a team November 28, 2025 20:54
@SimonADW SimonADW marked this pull request as draft November 28, 2025 21:22
@SimonADW
Copy link
Copy Markdown
Contributor Author

Hi! 👋

It looks like the CI check for this PR requires the changelog:bugfix-or-minor-feature label, but I’m not able to add or edit labels myself.

I can see the Labels section in the sidebar, but it’s read-only for me (no option to search or select labels), so I’m assuming my permission level on this repo doesn’t allow me to modify them.

Could someone with the right access please:

  • Add the changelog:bugfix-or-minor-feature label to this PR, or
  • Adjust my permissions so I’m able to set the required changelog labels on future PRs?

Thanks!

@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Nov 28, 2025
@yurishkuro yurishkuro changed the title Get pathname prop from withRouteProps Fix highlighting of the current tab in the main nav bar Nov 28, 2025
@yurishkuro yurishkuro marked this pull request as ready for review November 28, 2025 21:54
@yurishkuro yurishkuro merged commit d2c9eb3 into jaegertracing:main Nov 28, 2025
19 of 21 checks passed
@yurishkuro
Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Top nav highlighting is not working

2 participants