Fix highlighting of the current tab in the main nav bar#3183
Merged
Conversation
Destructure pathname from props to get the updated pathname passed down from withRouteProps rather than Redux. Update Props type to include IWithRouteProps as well as ReduxState Signed-off-by: SimonADW <[email protected]>
Contributor
Author
|
Hi! 👋 It looks like the CI check for this PR requires the I can see the Labels section in the sidebar, but it’s read-only for me (no option to search or select labels), so I’m assuming my permission level on this repo doesn’t allow me to modify them. Could someone with the right access please:
Thanks! |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Test Suites: 205 passed, 205 total
Tests: 2263 passed, 2263 total
Snapshots: 3 passed, 3 total
Time: 48.913 s
Ran all test suites.
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test