Skip to content

Remove defaultProps from ErrorMessage & NewWindowIcon #2609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Remove defaultProps from ErrorMessage & NewWindowIcon #2609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a4f2de
Remove defaultProps fromt ErrorMessage.tsx
ADI-ROXX Jan 23, 2025
bbe97b1
update-snapshots
ADI-ROXX Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 10 additions & 30 deletions ...-ui/src/components/DeepDependencies/Graph/DdgNodeContent/__snapshots__/index.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,7 @@ exports[`<DdgNodeContent> omits the operation if it is null 1`] = `
<span
className="DdgNodeContent--actionsItemIconWrapper"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</span>
<span
className="DdgNodeContent--actionsItemText"
Expand Down Expand Up @@ -291,9 +289,7 @@ exports[`<DdgNodeContent> omits the operation if it is null 2`] = `
<span
className="DdgNodeContent--actionsItemIconWrapper"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</span>
<span
className="DdgNodeContent--actionsItemText"
Expand Down Expand Up @@ -442,9 +438,7 @@ exports[`<DdgNodeContent> renders correctly when decorationValue is a string 1`]
<span
className="DdgNodeContent--actionsItemIconWrapper"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</span>
<span
className="DdgNodeContent--actionsItemText"
Expand Down Expand Up @@ -593,9 +587,7 @@ exports[`<DdgNodeContent> renders correctly when decorationValue is a string 2`]
<span
className="DdgNodeContent--actionsItemIconWrapper"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</span>
<span
className="DdgNodeContent--actionsItemText"
Expand Down Expand Up @@ -744,9 +736,7 @@ exports[`<DdgNodeContent> renders correctly when given decorationProgressbar 1`]
<span
className="DdgNodeContent--actionsItemIconWrapper"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</span>
<span
className="DdgNodeContent--actionsItemText"
Expand Down Expand Up @@ -898,9 +888,7 @@ exports[`<DdgNodeContent> renders correctly when given decorationProgressbar 2`]
<span
className="DdgNodeContent--actionsItemIconWrapper"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</span>
<span
className="DdgNodeContent--actionsItemText"
Expand Down Expand Up @@ -1049,9 +1037,7 @@ exports[`<DdgNodeContent> renders correctly when isFocalNode = true and focalNod
<span
className="DdgNodeContent--actionsItemIconWrapper"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</span>
<span
className="DdgNodeContent--actionsItemText"
Expand Down Expand Up @@ -1159,9 +1145,7 @@ exports[`<DdgNodeContent> renders correctly when isFocalNode = true and focalNod
<span
className="DdgNodeContent--actionsItemIconWrapper"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</span>
<span
className="DdgNodeContent--actionsItemText"
Expand Down Expand Up @@ -1278,9 +1262,7 @@ exports[`<DdgNodeContent> renders the number of operations if there are multiple
<span
className="DdgNodeContent--actionsItemIconWrapper"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</span>
<span
className="DdgNodeContent--actionsItemText"
Expand Down Expand Up @@ -1446,9 +1428,7 @@ exports[`<DdgNodeContent> renders the number of operations if there are multiple
<span
className="DdgNodeContent--actionsItemIconWrapper"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</span>
<span
className="DdgNodeContent--actionsItemText"
Expand Down
4 changes: 1 addition & 3 deletions ...eger-ui/src/components/DeepDependencies/SidePanel/__snapshots__/DetailsPanel.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,7 @@ exports[`<SidePanel> render renders detailLink 1`] = `
rel="noreferrer noopener"
target="_blank"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</a>
</Tooltip>
</div>
Expand Down
16 changes: 4 additions & 12 deletions packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/MetricCard.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,7 @@ exports[`MetricCard renders as expected when passCount is zero 1`] = `
rel="noreferrer noopener"
target="_blank"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</a>
</Tooltip>
</span>
Expand Down Expand Up @@ -109,9 +107,7 @@ exports[`MetricCard renders as expected with details 1`] = `
rel="noreferrer noopener"
target="_blank"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</a>
</Tooltip>
</span>
Expand Down Expand Up @@ -228,9 +224,7 @@ exports[`MetricCard renders as expected without details 1`] = `
rel="noreferrer noopener"
target="_blank"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</a>
</Tooltip>
</span>
Expand Down Expand Up @@ -305,9 +299,7 @@ exports[`MetricCard renders as expected without details 2`] = `
rel="noreferrer noopener"
target="_blank"
>
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</a>
</Tooltip>
</span>
Expand Down
12 changes: 3 additions & 9 deletions packages/jaeger-ui/src/components/QualityMetrics/__snapshots__/ScoreCard.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@ exports[`ScoreCard renders as expected when score is below max 1`] = `
target="_blank"
>
How to improve
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</a>
</div>
`;
Expand Down Expand Up @@ -57,9 +55,7 @@ exports[`ScoreCard renders as expected when score is max 1`] = `
target="_blank"
>
Great! What does this mean
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</a>
</div>
`;
Expand Down Expand Up @@ -90,9 +86,7 @@ exports[`ScoreCard renders as expected when score is zero 1`] = `
target="_blank"
>
How to improve
<NewWindowIcon
isLarge={false}
/>
<NewWindowIcon />
</a>
</div>
`;
25 changes: 2 additions & 23 deletions packages/jaeger-ui/src/components/common/ErrorMessage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ function ErrorAttr({ name, value }: ErrorAttrProps) {
);
}

export function Message(props: SubPartProps) {
const { className, error, wrap, wrapperClassName } = props;
export function Message({ className, error, wrap = false, wrapperClassName }: SubPartProps) {
const cssClass = `ErrorMessage--msg ${className || ''}`;

const msg =
Expand All @@ -66,15 +65,7 @@ export function Message(props: SubPartProps) {
return msg;
}

Message.defaultProps = {
className: undefined,
wrap: false,
wrapperClassName: undefined,
};

export function Details(props: SubPartProps) {
const { className, error, wrap, wrapperClassName } = props;

export function Details({ className, error, wrap = false, wrapperClassName }: SubPartProps) {
if (typeof error === 'string') {
return null;
}
Expand Down Expand Up @@ -113,12 +104,6 @@ export function Details(props: SubPartProps) {
return details;
}

Details.defaultProps = {
className: undefined,
wrap: false,
wrapperClassName: undefined,
};

export default function ErrorMessage({
className,
detailClassName,
Expand All @@ -140,9 +125,3 @@ export default function ErrorMessage({
</div>
);
}

ErrorMessage.defaultProps = {
className: undefined,
detailClassName: undefined,
messageClassName: undefined,
};
7 changes: 1 addition & 6 deletions packages/jaeger-ui/src/components/common/NewWindowIcon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,7 @@ type Props = {
isLarge?: boolean;
};

export default function NewWindowIcon(props: Props) {
const { isLarge, ...rest } = props;
export default function NewWindowIcon({ isLarge = false, ...rest }: Props) {
const cls = cx('NewWindowIcon', { 'is-large': isLarge });
return <IoOpenOutline className={cls} {...rest} data-testid="NewWindowIcon" />;
}

NewWindowIcon.defaultProps = {
isLarge: false,
};
Loading