Skip to content

Conversation

@hari45678
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • This PR fixes a minor bug that allows the submit button to be clicked even when entered duration in minDuration or maxDuration is invalid.
  • I have also changed a few variable names as per comments [1] & [2]

How was this change tested?

  • manually using npm run start and automated tests

Checklist

@hari45678 hari45678 requested a review from a team as a code owner January 20, 2025 06:59
@hari45678 hari45678 requested review from joe-elliott and removed request for a team January 20, 2025 06:59
@codecov
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (657cd00) to head (277bec7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2600   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files         255      255           
  Lines        7744     7745    +1     
  Branches     1998     1935   -63     
=======================================
+ Hits         7482     7483    +1     
  Misses        262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Jan 20, 2025
@yurishkuro yurishkuro merged commit 14837c3 into jaegertracing:main Jan 20, 2025
9 of 10 checks passed
@hari45678 hari45678 deleted the fix/disable-btn branch January 20, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants