[Bug]: When userconfg is not specified, the service cannot start.

[MicroOps-cn]

What happened?

When I use the v2 branch to create a chart through Helm and check the status of the pod, I encounter this error: configmap "user config" not found.
Looking at the source code of helm charts, it was found that a judgment was made at the configmap template. If the value of userconfig is not provided, the configmap will not be created. However, this judgment logic was not performed in the deploy template.

helm-charts/charts/jaeger/templates/user-config.yaml

Lines 2 to 13 in 2fa23fb

	{{ if .Values.userconfig }}
	apiVersion: v1
	kind: ConfigMap
	metadata:
	name: user-config
	namespace: {{ include "jaeger.namespace" . }}
	labels:
	{{- include "jaeger.labels" . | nindent 4 }}
	data:
	user-config.yaml: |
	{{- .Values.userconfig | nindent 4 }}
	{{- end }}

helm-charts/charts/jaeger/templates/collector-deploy.yaml

Lines 157 to 159 in 2fa23fb

	volumeMounts:
	- name: user-config
	mountPath: /etc/jaeger

helm-charts/charts/jaeger/templates/collector-deploy.yaml

Lines 198 to 201 in 2fa23fb

	volumes:
	- name: user-config
	configMap:
	name: user-config

Steps to reproduce

Commands used during deployment

git clone -b v2 https://github.com/jaegertracing/helm-charts.git
helm repo add incubator https://charts.helm.sh/incubator
helm repo add bitnami https://charts.bitnami.com/bitnami
helm dependency build helm-charts/charts/jaeger
helm upgrade --install jaeger helm-charts/charts/jaeger -f  values.yaml -n tracing

values.yaml used during deployment

storage:
  type: elasticsearch
  elasticsearch:
    host: <myesserver>
    port: 443
    scheme: https
    user: elastic
    password: <myespassword>

allInOne:
  enabled: false

query:
  enabled: true
  resources:
    limits:
      cpu: 500m
      memory: 512Mi
    requests:
       cpu: 256m
       memory: 128Mi
collector:
  enabled: true
  resources:
    limits:
      cpu: 1
      memory: 512Mi
    requests:
      cpu: 500m
      memory: 512Mi
  replicaCount: 1
  autoscaling:
    enabled: false
    minReplicas: 2
    maxReplicas: 5

spark:
  enabled: true
  resources:
    limits:
      cpu: 500m
      memory: 512Mi
    requests:
      cpu: 256m
      memory: 128Mi
config:
  extensions:
    jaeger_storage:
      backends:
        primary_store:
          elasticsearch:
            index_prefix: jaeger-primary
            server_urls: ["<myesserver-url>"]
            username: elastic
            password: <myespassword>
          memory:
            max_traces: 100000
        archive_store:
          elasticsearch:
            index_prefix: jaeger-archive
            server_urls: ["<myesserver-url>"]
            username: elastic
            password: <myespassword>
          memory:
            max_traces: 100000

Expected behavior

The service is running normally

Relevant log output

kubectl describe pods  -n tracing jaeger-collector-fd7f97468-z9bq7
...
Events:
  Type     Reason       Age                 From               Message
  ----     ------       ----                ----               -------
  Normal   Scheduled    2m6s                default-scheduler  Successfully assigned tracing/jaeger-collector-fd7f97468-z9bq7 to ip-xxxx.us-east-2.compute.internal
  Warning  FailedMount  62s (x8 over 2m6s)  kubelet            MountVolume.SetUp failed for volume "user-config" : configmap "user-config" not found

Screenshot

No response

Additional context

No response

Jaeger backend version

2.0.0-rc2

SDK

No response

Pipeline

No response

Stogage backend

No response

Operating system

No response

Deployment model

No response

Deployment configs

[yildizozgur]

and even when you set this configmap it still annoys elasticsearch configs . I could not find correct keys for them.

'elasticsearch' has invalid keys: password, username

[MicroOps-cn]

and even when you set this configmap it still annoys elasticsearch configs . I could not find correct keys for them.

'elasticsearch' has invalid keys: password, username

Indeed, I carefully analyzed the helm chart and found that it is based on version v1
On the one hand, some v1 versions of the configuration are no longer supported (for example, environment variables such as ESESERVER-URLS are no longer supported in v2)
On the other hand, some configurations in values such as config.service, config.extensions, config.receivers have not been called in the template, and must be passed in through userconfig for jaeger to read the configuration

[yildizozgur]

and even when you set this configmap it still annoys elasticsearch configs . I could not find correct keys for them.
'elasticsearch' has invalid keys: password, username

Indeed, I carefully analyzed the helm chart and found that it is based on version v1 On the one hand, some v1 versions of the configuration are no longer supported (for example, environment variables such as ESESERVER-URLS are no longer supported in v2) On the other hand, some configurations in values such as config.service, config.extensions, config.receivers have not been called in the template, and must be passed in through userconfig for jaeger to read the configuration

Thank you very much @MicroOps-cn

[Liubey]

@MicroOps-cn same phenomenon with you. How to resolve it? When I create a blank user-config, the Pod will failure to exit.
@yurishkuro Hi Boss, Is V2 helm chats can run without user-config?

[MicroOps-cn]

@MicroOps-cn same phenomenon with you. How to resolve it? When I create a blank user-config, the Pod will failure to exit. @yurishkuro Hi Boss, Is V2 helm chats can run without user-config?

Put all Jaeger configurations under userconfig and also provide storage related configurations under storage, like this:

storage:
  type: elasticsearch
  elasticsearch:
    host: xxxxxxxxxxxxxx.xxxx.aws.elastic-cloud.com
    port: 443
    scheme: https
    user: elastic
    password: xxxxxxxxxxxxxxxxxx
# Pay attention to the following after userconfig:`|-`
userconfig: |-
  service:
    extensions: [jaeger_storage, jaeger_query, healthcheckv2]
    pipelines:
      traces:
        receivers: [otlp]
        processors: [filter,batch]
        exporters: [jaeger_storage_exporter, spanmetrics]
      metrics/spanmetrics:
        receivers: [spanmetrics]
        exporters: [prometheus]
    telemetry:
      resource:
        service.name: jaeger
      metrics:
        level: detailed
        readers:
          - pull:
              exporter:
                prometheus:
                  host: 0.0.0.0
                  port: 8888
      logs:
        level: DEBUG
  extensions:
    healthcheckv2:
      use_v2: true
      http:
        endpoint: 0.0.0.0:13133

    jaeger_query:
      storage:
        traces: primary_store
        metrics: metrics_store

    jaeger_storage:
      backends:
        primary_store:
          elasticsearch:
            indices:
              index_prefix: jaeger-primary
            server_urls: ["https://xxxxxxxxxxxxxx.xxxx.aws.elastic-cloud.com:443"]
            auth:
              basic:
                user: elastic
                password: xxxxxxxxxxxxxxxxxx
      metric_backends:
        metrics_store:
          prometheus:
            endpoint: http://k8s-prometheus.monitoring:9090
            normalize_calls: true
            normalize_duration: true
.....