-
Notifications
You must be signed in to change notification settings - Fork 55
Add documentation for accepting multiple config locations #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
README.md
Outdated
| } | ||
| } | ||
| return obj1; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's in documentation, I think it would be better to use a library like lodash/merge or deepmerge for clarity - this is a lot of non-gulp-load-plugins code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! I actually found extend to work really well -- I'll update it with that one, but if the others are more preferred I'm fine either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat 👍
|
Looks good! Mega pedantic, but could you use Lodash as the library that provides extend? Just because that's most popular and understood I think. Really appreciate your efforts here, be sure to add yourself to the contributors list in the |
|
Sure thing, updated! |
|
(Sorry) but could you change the sentence before the code example to point to Lodash, not to extend? :) |
|
Oof, updated |
|
👍 thank you! |
As discussed in #124