Updating OpenVR bindings #937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated OpenVR JNA binding from 1.0.9 to 1.0.16 Added OpenVR/LWJGL binding using KWJGL 3.2.0
Merged
Contributor
|
Maybe this is the best compromise for the time being. I'd like for lwjgl to be the default choice and that code sharing is maximized (which it seems to be from the code). The reason is since the rest of the engine is lwjgl based, it makes sense. I agree that jme is sometimes slow to adapt to new versions, but with gradle it's easy for a user to choose any version they like. It also means we can defer a lot of support questions to lwjgl, it's well documented, etc etc. I assume that over time, someone will migrate oculus bindings as well. |
Contributor
Author
|
Maybe this PR can be accepted ? |
Contributor
|
I don't have time to work more on this for the time being. But will pick up on it in due time. Thanks. |
Member
|
Thanks, both of you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated OpenVR JNA binding from 1.0.9 to 1.0.16
Added OpenVR/LWJGL binding using KWJGL 3.2.0