Skip to content

Conversation

@richardTingle
Copy link
Member

@richardTingle richardTingle commented Jun 23, 2025

Add new screenshot tests for bill boarding, cartoons, fog and scattering

@github-actions
Copy link

🖼️ Screenshot tests have failed.

The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests.

📄 Where to find the report:

  • Go to the (failed run) > Summary > Artifacts > screenshot-test-report
  • Download the zip and open jme3-screenshot-tests/build/reports/ScreenshotDiffReport.html

⚠️ If you didn't expect to change anything visual:
Fix your changes so the screenshot tests pass.

If you did mean to change things:
Review the replacement images in jme3-screenshot-tests/build/changed-images to make sure they really are improvements and then replace and commit the replacement images at jme3-screenshot-tests/src/test/resources.

If you are creating entirely new tests:
Find the new images in jme3-screenshot-tests/build/changed-images and commit the new images at jme3-screenshot-tests/src/test/resources.

Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar".

See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information

@richardTingle richardTingle marked this pull request as ready for review June 23, 2025 19:47
@yaRnMcDonuts yaRnMcDonuts added this to the v3.9.0 milestone Jun 24, 2025
@yaRnMcDonuts
Copy link
Member

Thanks for adding more screenshot tests! They are already proving to be very useful.

I'll merge this PR soon, that way any other PRs I merge today have these new tests run first.

@yaRnMcDonuts yaRnMcDonuts merged commit 8ff17a8 into jMonkeyEngine:master Jun 24, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants