Skip to content

Improve LightControl Javadoc & Add Light Type Validation #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaRnMcDonuts merged 10 commits into from
Jun 15, 2025
Merged

Improve LightControl Javadoc & Add Light Type Validation #2451

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
334a733
Update LightControl: add validateSupportedLightType() method
capdevon May 23, 2025
826c860
Update exception message
capdevon May 23, 2025
9612b18
Update LightControl: add axisRotation control
capdevon May 23, 2025
133dac7
fix wrong lightDirection
capdevon Jun 1, 2025
0c8aa04
Update LightControl: add axisRotation and axisDirection enum
capdevon Jun 5, 2025
8911d07
Update LightControl: add toString method
capdevon Jun 5, 2025
99f6b9d
LightControl: fix lightToSpatial
capdevon Jun 5, 2025
1af2acf
LightControl: replace axisDirection enum with invertAxisDirection boo…
capdevon Jun 7, 2025
2632bd9
LightControl: setLight(Light) allows you to set null light
capdevon Jun 9, 2025
81fbfd9
LightControl: update toString() method
capdevon Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions jme3-core/src/main/java/com/jme3/scene/control/LightControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,10 @@ public void setInvertAxisDirection(boolean invertAxisDirection) {
}

private void validateSupportedLightType(Light light) {
if (light == null) {
return;
}

switch (light.getType()) {
case Point:
case Directional:
Expand All @@ -172,6 +176,10 @@ private void validateSupportedLightType(Light light) {

@Override
protected void controlUpdate(float tpf) {
if (light == null) {
return;
}

switch (controlDir) {
case SpatialToLight:
spatialToLight(light);
Expand Down