Skip to content

Fix non decimal format floats in TangentUtils.glsllib #2389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaRnMcDonuts merged 1 commit into from
Mar 6, 2025
+2 −1
Merged

Fix non decimal format floats in TangentUtils.glsllib #2389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion jme3-core/src/main/resources/Common/ShaderLib/TangentUtils.glsllib
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
//used for calculating tangents in-shader for axis-aligned quads/planes/terrains
//primarily used for PBR terrains, since jme terrains do not store pre-calculated tangents by default (thus the tbnMat cannot be used for PBR light calculation like it is in jme's stock PBR shader)
vec3 calculateTangentsAndApplyToNormals(in vec3 normalIn, in vec3 worldNorm){
vec3 baseNorm = worldNorm.rgb + vec3(0, 0, 1);
vec3 baseNorm = worldNorm.rgb + vec3(0.0, 0.0, 1.0);
normalIn *= vec3(-1.0, 1.0, 1.0);
normalIn = baseNorm.rgb*dot(baseNorm.rgb, normalIn.rgb)/baseNorm.z - normalIn.rgb;
normalIn = normalize(normalIn);

Expand Down