Fix Fog in Lighting.frag #2364
Merged
Fix Fog in Lighting.frag #2364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR addresses this issue: #2363
Member
Author
|
I also removed a line of code that listed the author of the fog where it gets implemented in Lighting.frag. Crediting the author of each individual feature or code segment throughout a fragment shader does not seem like a good practice and would quickly make the file cluttered with unnecessary comments if more people did this. And it is ultimately unnecessary considering github already keeps track of who made each commit. But to ensure they still are credited for their work, I added a comment at the top of MaterialFog.glsllib listing them as the original author of this feature. |
stephengold
added
the
bug
Member
Author
|
I plan to merge this PR in 24 hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this issue: #2363