[Android] Fix Android JmeSurfaceView Memory Leak #2359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I plan to merge this in 24 hours. |
Contributor
Author
In that regard, you might want to link this PR to its issue before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a fix to:
The following are introduced into this PR:
JmeSurfaceView: corrected the algorithm by which theSystemListener#destroy()concrete implementation is being dispatched by the Activity Lifecycle.JmeSurfaceViewdocumentation: clarified the usage and the behavior ofJmeSurfaceView.DestructionPolicy.OGLESContext: released the used weak references to theGlSurfaceViewcomponent that is being passed using the handlerOGLESContext#createView(Context).