AnimComposer: return AnimLayer on the makeLayer and removeLayer methods. #2231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Are there any updates on this proposal? Has anyone had a chance to review it? |
codex128
approved these changes
Oct 26, 2024
Contributor
codex128
left a comment
codex128
left a comment
There was a problem hiding this comment.
These changes look fine to me.
neph1
approved these changes
Oct 27, 2024
Contributor
neph1
left a comment
neph1
left a comment
There was a problem hiding this comment.
I'd take the opportunity to rename "l" "layer", but the method is so short it doesn't really matter.
Member
|
I used GitHub's web editor to resolve the merge conflict. |
Member
|
That broke the build. Hang on while I fix it... |
Member
|
All set. Thanks for this contribution, @capdevon ! |
This was referenced Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize the
AnimComposer.makeLayer()andAnimComposer.removeLayer()methods similar toAnimComposer.makeAction()andAnimComposer.removeAction()to simplify interaction with created and deleted objects.