By default use PrimitiveAllocator on Android #2029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Unless there's something to discuss, I plan to self-integrate this PR in about 24 hours. |
bob0bob
added a commit
to bob0bob/jmonkeyengine
that referenced
this pull request
Jun 8, 2023
Co-authored-by: Ali-RS <[email protected]>
stephengold
pushed a commit
that referenced
this pull request
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes PrimitiveAllocator the default buffer allocator due to a memory leak issue with AndroidNativeBufferAllocator.
See issue #1990
In the below link you can find out why direct byte buffers allocated via JNI (
env->NewDirectByteBuffer()) are not cleaned when GCed but the ones created withByteBuffer.allocateDirect()are cleaned with GC.https://stackoverflow.com/a/35364247