Skip to content

solve issue #2011 (app crashes when using OpenGL version 3.0 and 3.1 with LWJGL 3) #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephengold merged 3 commits into from
May 15, 2023
Merged

solve issue #2011 (app crashes when using OpenGL version 3.0 and 3.1 with LWJGL 3) #2009

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11b7c9e
fix system crush issue when set desktop AppSetting.setRenderer below 3.2
aspenyoung May 15, 2023
dabda49
Revert "fix system crush issue when set desktop AppSetting.setRendere…
aspenyoung May 15, 2023
e433359
fix system crush issue when set desktop AppSetting.setRenderer below …
aspenyoung May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions jme3-lwjgl3/src/main/java/com/jme3/system/lwjgl/LwjglWindow.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,16 @@ public abstract class LwjglWindow extends LwjglContext implements Runnable {

static {
RENDER_CONFIGS.put(AppSettings.LWJGL_OPENGL30, () -> {
// Based on GLFW docs for OpenGL version below 3.2,
// GLFW_OPENGL_ANY_PROFILE must be used.
glfwWindowHint(GLFW_OPENGL_PROFILE, GLFW_OPENGL_ANY_PROFILE);
glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 3);
glfwWindowHint(GLFW_CONTEXT_VERSION_MINOR, 0);
});
RENDER_CONFIGS.put(AppSettings.LWJGL_OPENGL31, () -> {
// Based on GLFW docs for OpenGL version below 3.2,
// GLFW_OPENGL_ANY_PROFILE must be used.
glfwWindowHint(GLFW_OPENGL_PROFILE, GLFW_OPENGL_ANY_PROFILE);
glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 3);
glfwWindowHint(GLFW_CONTEXT_VERSION_MINOR, 1);
});
Expand Down