Skip to content

BlendableAction: Fix JavaDoc for setMaxTransitionWeight & replace assert with IllegalArgumentException #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ali-RS merged 1 commit into from
Dec 21, 2022
Merged

BlendableAction: Fix JavaDoc for setMaxTransitionWeight & replace assert with IllegalArgumentException #1881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions jme3-core/src/main/java/com/jme3/anim/tween/action/BlendableAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,13 @@ protected float getTransitionWeight() {
}

/**
* @param maxTransitionWeight The max transition weight. Must be >0 and <1 (default=1)
* @param maxTransitionWeight The max transition weight. Must be >=0 and <=1 (default=1)
* @throws IllegalArgumentException If maxTransitionWeight is not between 0 and 1.
*/
public void setMaxTransitionWeight(double maxTransitionWeight) {
assert maxTransitionWeight >= 0 && maxTransitionWeight <= 1;
if (maxTransitionWeight < 0.0 || maxTransitionWeight > 1.0) {
throw new IllegalArgumentException("maxTransitionWeight must be between 0 and 1");
}

this.maxTransitionWeight = maxTransitionWeight;
}
Expand Down