-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
work around missing reshape() callbacks from LWJGL v3 (issue #1793) #1794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Lying in bed this morning, I came up with a simpler, more elegant fix. |
Member
Author
|
Here's a summary:
|
Ali-RS
reviewed
Mar 31, 2022
Member
Author
|
Unless there's more to discuss, I propose to self-integrate this PR in about 24 hours. |
Member
Author
|
In order to backport this into "v3.5" branch, we'd also need to backport #1750. The combination of the 2 PRs seems risky relative to the benefits. Better wait for 3.6 or 4.0 |
This was referenced Feb 9, 2023
Member
|
Looks like this breaks TestAWTPanels, please see #1945 |
Ali-RS
reviewed
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the observations documented in #1793, the key issue is that transitions between windowed mode and fullscreen mode in LWJGL v3 don't always generate
reshape()callbacks. This spoils GUI layouts that need updating each time the dimensions of the graphics context change. The user sees a layout generated for a different-sized framebuffer.(There's also an issue with the initial
reshape()callback, which occurs on Windows, but not Linux, when the initial context is created. However, that's an easy issue for apps to work around.)The key issue manifests differently on Linux than on Windows:
This PR proposes that jme3-lwjgl3's
LwjglWindowshould explicitly invokereshape()on both windowed-to-fullscreen and fullscreen-to-windowed transitions. This results in some redundant callbacks (multiple callbacks for a singlecreateContext()). However, I expect mostreshape()callbacks perform idempotent operations. Also, filtering out redundant callbacks is much easier that compensating for missing callbacks.