using deprecated FrameBuffer methods in jme3-core and jme3-desktop #1657 #1696
Conversation
… in AppSettings. ‘CenterWindow’, ‘WindowXPosition’ and ‘WindowYPosition’ variables. This way these variable will be saved in the profile when the profile is saved, and be reloaded. I added ‘CenterWindow’ to be added with a ‘true’ value for the default value so it will run just like it did before. But if you set ‘CenterWindow’ to ‘false’ then inside LwjglWindow.java (lwjgl3 code) it will look at these new values, it will determine to center the window or use the position values to place the window back at the location the user last moved it to. Of course, these values are only updated if the “program” updates this value. So if you want to save screen position, you can save them on closing to and on restart put the window back into the same location.
LWJGL3-JME library would block the current thread when executing LWJGL3. Instead of calling run() that is blocking, made it work like LWJGL2-JME library when they start it as a thread so run gets called. I commented out the run() function and replaced it with Thread.start().
LWJGL3-JME projects was doing a call that is blocking the current thread. I changed it to match how LWJGL2-JME project launches the Context Window.
LWJGL3-JME projects was doing a call that is blocking the current thread. I changed it to match how LWJGL2-JME project launches the Context Window.
…MonkeyEngine#1657 Updating all references to setDepthTexture and setColorTexture from old system to the new system.
|
Please go back check for unused imports in the files you modified. |
|
They are removed. |
|
Codacy thinks there are still 2 new unused imports in AbstractShadowRendererVR.java |
|
What 2 imports. My environment doesn't show any unused. I see 2 in AbstractShadowFilterVR.java |
|
com.jme3.texture.FrameBuffer.FrameBufferBufferTarget |
|
Got looking at wrong branch. |
|
The code formatting is inconsistent, but it'll be easier for me to fix that directly during integration than to explain precisely what I want changed. I'm uneasy about adding static methods to the My biggest concern is test coverage. What tests have you run with these changes?
That happens to me often. You have my sympathy. |
|
do you guys have a document on formatting requirements. I know many people have profiles for different environments so you can use that directly and it has the same style. |
We recently added Java style guidelines to CONTRIBUTING.md. It's basically Google style with a handful of local mods. It covers formatting as well as other style issues such as naming and javadoc. |
|
What tests have you run with these changes? |
|
I would test . I ran them against all the test applications that where altered. That should about cover it all. |
|
Alright, then. Thanks for your contribution! |
2 participants
Updating all references to setDepthTexture and setColorTexture from old system to the new system.