Skip to content

fix issues #1193 and #1558 for Linux/Windows (LWJGL v3 hangs) #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephengold merged 23 commits into from
Dec 6, 2021
Merged

fix issues #1193 and #1558 for Linux/Windows (LWJGL v3 hangs) #1690

Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
91a49ec
This is a very simple addition. It allows a person to set 3 variables…
bob0bob Nov 22, 2021
7bcba98
Merge branch 'master' of https://github.com/bob0bob/jmonkeyengine
bob0bob Nov 22, 2021
ce24716
formatting and comments changes.
bob0bob Nov 24, 2021
aef358f
jme3test.app.TestApplication hangs with LWJGL3 #1193
bob0bob Nov 24, 2021
1b0507e
Merge branch 'jMonkeyEngine:master' into master
bob0bob Nov 25, 2021
f0489b8
removing unwanted changes, since you can't do multiple pull requests …
bob0bob Nov 25, 2021
e5f608d
Merge branch 'master' of https://github.com/bob0bob/jmonkeyengine int…
bob0bob Nov 25, 2021
a5b0e37
formatting issues.
bob0bob Nov 25, 2021
26937ca
changed parameter naming to be more consistency with other items.
bob0bob Nov 25, 2021
3832d37
jme3test.app.TestApplication hangs with LWJGL3 #1193
bob0bob Nov 25, 2021
811493c
jme3test.app.TestApplication hangs with LWJGL3 #1193 (#3)
bob0bob Nov 25, 2021
db0d9ff
removing unwanted changes.
bob0bob Nov 25, 2021
5eb2690
AppSettings: enhance the new javadoc
stephengold Nov 30, 2021
72d008d
AppSettings: capitalize Window{X/Y}Position consistent w/other settings
stephengold Nov 30, 2021
f7c5ec7
LwjglWindow: convert tabs to spaces
stephengold Nov 30, 2021
4544d64
AppSettings: re-arrange @see tags in javadoc
stephengold Nov 30, 2021
0d28d62
Merge branch 'jMonkeyEngine:master' into master
bob0bob Dec 1, 2021
03f795a
TestAWTPanels hangs with LWJGL v3 #1558 / jme3test.app.TestApplicat…
bob0bob Dec 1, 2021
2f85213
TestAWTPanels hangs with LWJGL v3 #1558 / jme3test.app.TestApplicati…
bob0bob Dec 2, 2021
83ed844
Removed the string compare to determine if it is a Mac OS. Using LWJ…
bob0bob Dec 3, 2021
d49e36e
Making changes for Mac os. The AWT examples will not work under Mac …
bob0bob Dec 3, 2021
c39eb23
added braces that are need for formatting.
bob0bob Dec 6, 2021
fb74379
LwjglWindow: copyright year, log message, correct indents and braces
stephengold Dec 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions jme3-lwjgl3/src/main/java/com/jme3/system/lwjgl/LwjglWindow.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2009-2020 jMonkeyEngine
* Copyright (c) 2009-2021 jMonkeyEngine
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
Expand Down Expand Up @@ -57,6 +57,8 @@
import java.util.logging.Logger;
import org.lwjgl.Version;
import org.lwjgl.glfw.*;
import org.lwjgl.system.Platform;

import static org.lwjgl.glfw.GLFW.*;
import static org.lwjgl.opengl.GL11.GL_FALSE;
import static org.lwjgl.system.MemoryUtil.NULL;
Expand Down Expand Up @@ -477,10 +479,21 @@ public void create(boolean waitFor) {
return;
}

// NOTE: this is required for Mac OS X!
mainThread = Thread.currentThread();
mainThread.setName("jME3 Main");
run();
if (Platform.get() == Platform.MACOSX) {
// NOTE: this is required for Mac OS X!
mainThread = Thread.currentThread();
mainThread.setName("jME3 Main");
if (waitFor) {
LOGGER.warning("create(true) is not supported for macOS!");
}
run();
} else {
new Thread(this, "jME3 Main").start();
if (waitFor) {
waitFor(true);
}
}

}

/**
Expand Down