Adds getters/setters for Camera field of view and aspect ratio #1492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the perspective camera.
What was I thinking? We already have the resize method!
stephengold
reviewed
Mar 25, 2021
stephengold
reviewed
Mar 25, 2021
stephengold
reviewed
Mar 25, 2021
stephengold
reviewed
Mar 25, 2021
stephengold
reviewed
Mar 25, 2021
Reversing the calculations is more accurate.
Contributor
Author
|
I honestly have no idea why the Linux javadoc task failed. Is there a way to rerun it? Perhaps it was just a hiccup, especially since everything else (including Linux on JDK11) worked. |
Member
|
The only way I know to rerun a check/job is to rerun them all. Note the "Re-run jobs" button on the right side: |
Contributor
Author
|
I'm not seeing the button. I'm guessing that I don't have the appropriate permissions to so. Its not a big deal. We can rerun them after we finish the last of the issues for this. |
Contributor
Author
|
O.K., I guess the failed job was a fluke. It worked fine this time. |
stephengold
requested changes
Apr 2, 2021
jme3-examples/src/main/java/jme3test/renderer/TestAspectFov.java
Outdated
Show resolved
Hide resolved
jme3-examples/src/main/java/jme3test/renderer/TestAspectFov.java
Outdated
Show resolved
Hide resolved
stephengold
changed the title
stephengold
approved these changes
Apr 5, 2021
Member
stephengold
left a comment
stephengold
left a comment
There was a problem hiding this comment.
Thanks for the changes. Looks fine now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in https://hub.jmonkeyengine.org/t/getter-setter-methods-for-attribute-fieldofview-in-the-class-camera-java-in-jme-3-4/44426/9 and mentioned in #1491, I added getter and setter methods for the field of view for perspective cameras (calling these methods on an orthogonal camera has no effect). These can be easily tested on any example that uses the FlyByCamera (i.e., 90% of them), but I added a new test for it just the same that actually displays the current FOV.