AppStateManager profiler for render and post render #1485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I don't object to it... but it's interesting that of the thousands of app states that I've written in various apps, maybe half a dozen do anything significant on render() or postRender(). |
Contributor
Author
|
Yeah, this came up when troubleshooting Minie's BulletAppState which does blocking on render or post render depending if running in sequential or parallel. I would have never figured out it was bullet without this. |
Member
|
I'm okay with this. Ready for integration. |
Contributor
Author
|
It is ready to merge when ever you are. |
danielperano
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added profile tracking to AppStateManager for render and post render.
If the community thinks this is useful, feel free to merge, otherwise just close. I found it very helpful when tracing which app state was impacting my fps.